1229593 - Find in Page: Support searching from text selection

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

Selecting a word to search is an alternate entry point from the find bar. See https://mozilla.invisionapp.com/share/JK51NBM69#/screens/117336830.

Comment 1

[Stephan Leroux [:sleroux]]

Just for reference, I'm working on a similar bug for the login manager where we show a custom 'Reveal' option using a custom UIMenuItem:

https://bugzilla.mozilla.org/show_bug.cgi?id=1221688

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1408

Comment 3

[Brian Nicholson (:bnicholson)]

There's one issue I found when testing this, which is that if you try to select text while the find-in-page bar is already visible and focused, the selected text menu won't have Find in Page as an option. I think this is because the web view isn't the first responder, so it doesn't get asked which items to show.

Maybe we could set the web view to the first responder right on touch down? Not sure what the best solution is yet...let me know if you have any ideas. Will probably push the fix off to a follow-up bug.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8704744 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1408

As discussed in triage, I'd be fine with landing this as is with the UIMenuAction bug and filing a follow up to investigate.

Comment 5

[Brian Nicholson (:bnicholson)]

https://github.com/mozilla/firefox-ios/commit/887fd24082c419f49b159e73c9926708eaf7b331

Comment 6

[Catalin Suciu [:csuciu]]

Verifying as fixed on build 2.0(3)