1229694 - [devedition theme] Toolbar button active/open styles are not correctly applied in normal (non-private) windows

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[arni2033]

Attachment: screenshot 1 - [dev theme] Toolbar buttons styling is inconsistent.png

>>>   My Info:   Win7_64, Nightly 45, 32bit, ID 20151201030226
STR:
1. Open menu (≡) -> customization, set Devtools theme   (dark or light theme - doesn't matter)
2. Open private browser window and not private one
3. Click menu button (≡) in private window and in not private one

Result:       
 The visual appearance of buttons is different

Expectations: 
 The buttons with opened widgets/popups should look the same (like buttons in private window).
 I first thought that the intent was to completely change the styling, but in bug 1215093 noone even
 mentioned devtools theme (which is also "lightweight theme" somehow). So it clearly wasn't planned

I set keyword "regression" because styling became inconsistent

Comment 1

[:Gijs (he/him)]

Dão, any chance you can look at this - last beta is this week, and the regressing bug was uplifted to 43. :-(

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #1)
> Dão, any chance you can look at this - last beta is this week, and the
> regressing bug was uplifted to 43. :-(

How is that relevant given that this is a dev edition bug?

Comment 3

[:Gijs (he/him)]

(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to :Gijs Kruitbosch from comment #1)
> > Dão, any chance you can look at this - last beta is this week, and the
> > regressing bug was uplifted to 43. :-(
> 
> How is that relevant given that this is a dev edition bug?

Is it? The original bug changed lwthemes, it seems likely this will affect those, too.

Comment 4

[Dão Gottwald [:dao]]

Ordinary lightweight themes aren't affected as far as I can tell.

Comment 5

[arni2033]

Notably that it was marked as dependent on bug 854126 that is going to break this completely.

Comment 6

[Dão Gottwald [:dao]]

I believe bug 1314091 and bug 854126 fixed this.