Closed
Bug 1231025
Opened 9 years ago
Closed 7 years ago
[UX] Text twitching when editing URL due to the current Identity Block design
Categories
(Firefox :: Site Identity, defect)
Firefox
Site Identity
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox45 | --- | affected |
People
(Reporter: arni2033, Unassigned)
References
Details
(Whiteboard: [fxprivacy])
User Story
> Screencasts:
>
> [Dropbox Folder] https://www.dropbox.com/sh/zyxo13vkchl2bjl/AABcEOdvCZyKuu0Uy2rawHpIa?dl=0
> [1] - Doorhanger https://dl.dropboxusercontent.com/s/opv1g5hxp7sozzp/%5B1%5D%20-%20Doorhanger.webm?dl=0
> [2] - Identity labels https://dl.dropboxusercontent.com/s/qc9dfpn3eu9kama/%5B2%5D%20-%20Identity%20labels.webm?dl=0
> [3] - "Switch to tab" label https://dl.dropboxusercontent.com/s/ygfkak2db2r6k0f/%5B3%5D%20-%20%27Switch%20to%20tab%27%20label.webm?dl=0
> [4] - Notifications https://dl.dropboxusercontent.com/s/muiq9bxm8tpps1p/%5B4%5D%20-%20Notifications.webm?dl=0
> [5] - Tracking protection https://dl.dropboxusercontent.com/s/gnp07uxtpiv6qyq/%5B5%5D%20-%20Tracking%20protection.webm?dl=0
> [6] - Overall distracting behavior https://dl.dropboxusercontent.com/s/zidhrn200leugw4/%5B6%5D%20%28bonus%29%20-%20Overall%20distracting%20behavior.webm?dl=0
> [7] - Forward button [N/A]
>
>
> Regressions:
>
> What has regressed Date Bug Pushlog_url
> [1] - Doorhanger 2015-11-12 - 2015-11-13 bug 1206244 https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cd88c2150e1ee4574e78ce1199911ed9a16f366a&tochange=a4ce197dfecef223c0e9f84ab3bc1fc27c5cf0cb
> [2] - Identity labels 2012-05-27 - 2012-05-28 bug 667586 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=133aa3a2ef0a&tochange=79262a88881d
> [3] - "Switch to tab" label 2010-03-26 - 2010-03-27 bug 480350 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7300722add8a&tochange=82d527d82812
> 2010-12-10 - 2010-12-11 bug 596485 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a4544a4b3224&tochange=e42d81b3e0cc
> [4] - Notifications [N/A]; step-by-step bug 398776 [N/A]
> [5] - Tracking protection 2015-07-28 - 2015-07-29 bug 1184060 https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=b21f74e37b604a05b61837925ccef10355b7288e&tochange=8420f6ffc2dbba3798afcdf444d68575266be435
Attachments
(1 file)
>>> My Info: Win7_64, Nightly 45, 32bit, ID 20151206030448
[1] - Doorhanger
STR:
1. Open https://mail.ru/
2. Click text in urlbar to select it
3. Type "a"
Result: Doorhanger icon disappears and text twitches to the left.
[2] - Identity labels
STR:
1. Open https://www.mozilla.org/en-US/
2. Click text in urlbar to select it
3. Type "a"
Result: identity-icon-labels disappear and text twitches to the left.
[3] - "Switch to tab" label
STR:
1. Open url "data:text/html,<title>unique20151207224723" (without quotes) in a new tab
2. Open new tab
3. Type there "unique20151207224723" without quotes
4. Press Down key to select the item "Switch to tab" from urlbar suggestions
5. Make sure that cursor is placed in the end of the text. Otherwise press End key.
6. Hold Shift key (don't release it until Step 8)
7. Press Left key to select the word "unique20151207224723"
8. Release Shift key, then Ctrl key
9. Type "test" to get "data:text/html,<title>test"
Result: After Step 4 "Switch to tab" appears and text in urlbar twitches to the Right
After Step 6 "Switch to tab" disappears and text in urlbar twitches to the Left
After Step 8 "Switch to tab" appears and text in urlbar twitches to the Right
After Step 9 "Switch to tab" disappears and text in urlbar twitches to the Left
Note that I often perform this natural STR to (e.g.) edit number of bug in bugzilla url
[4] - Notifications
STR:
1. Open "testcase 1"
2. Click text in urlbar to select it
3. Start typing "abcd..." in urlbar before plugin notification appears (you've got 4 seconds)
4. Continue typing until plugin notification appears in urlbar
Result: Plugin notification appears in urlbar and text twitches to the right
[5] - Tracking protection
STR:
1. Save "testcase 1" locally and open the local .html file in private tab
2. Click text in urlbar to select it
3. Type "a" in urlbar before plugin notification appears (you've got 4 seconds)
4. When plugin notification will appear, press Escape twice to cancel urlbar input
Result: Tracking protection icon appears in urlbar and text twitches to the right
[6] - Overall distracting behavior
STR:
1. Open https://www.mozilla.org/en-US/
2. Type "http://example.com/" in urlbar, then press Enter to load the site
3. Press Alt+Left
Result: forward button, identity icons, identity labels appear at once, and the text twitches
they are very distracting+annoying even if I don't look at the text in urlbar
[7] - Forward button
This case will be actual once bug 1199934 is resolved.
Expectations: Text in urlbar should stay still.
Comment hidden (obsolete) |
Updated•9 years ago
|
Whiteboard: [fxprivacy] [triage]
I listed all bugs that regressed this in "User story"
User Story: (updated)
Updated•9 years ago
|
Whiteboard: [fxprivacy] [triage]
Comment 3•9 years ago
|
||
Thanks a lot for the detailed steps to reproduce and screencasts!
We should definitely improve upon this design. The main reason for which we compress the Identity Block, as you can imagine, is that we want to provide more real estate for seeing the URL while editing it. We should find ways to do this but avoid the constant twitching when using the keyboard around the address bar.
The Privacy and Security team I'm part of will not be able to work on this, but I can see this bug tracked as part of our more general Quality efforts.
Justin, is there a tag or meta-bug we could use to track this bug? (I'd ask Gijs but he's away for some time.)
Flags: needinfo?(dolske)
Keywords: regression
Summary: Current design leads to constant text twitching in urlbar → Text twitching when editing URL due to the current Identity Block design
Comment 4•9 years ago
|
||
(I've also been out over the holidays.)
There isn't a more specific tag, this seems like a fine bug to use itself for the general issue.
Flags: needinfo?(dolske)
Comment 5•8 years ago
|
||
(In reply to arni2033 from bug 1300755 comment #42)
> What you are doing is breaking bug 1231025 even more.
We have two main options here. One is to keep the start position of the URL, and have less available space for typing, like you are suggesting. The other is to extend the available space by reclaiming the space used by the security indicators. Even with the first option, we would have to hide or dim the security indicators anyways, since they don't apply to the new URL, but we could keep the space allocated.
The second option is what is currently implemented. Whether this is more or less broken than the other choice can be debated, because having less space to view and type the URL can be considered another type of breakage by different users. In bug 1300755, we are continuing the current behavior without changing it, and making it more consistent in that direction. This doesn't mean we cannot change direction later, of course.
> Apparently, UX team haven't ever read that bug... Please read it.
I'll mark this for triage, because recently our team took more ownership of that area of the user interface. This will get it in front of the right people in a shorter time. Thanks for the reminder!
Component: General → Site Identity and Permission Panels
Summary: Text twitching when editing URL due to the current Identity Block design → [UX] Text twitching when editing URL due to the current Identity Block design
Whiteboard: [fxprivacy][triage]
Comment 6•8 years ago
|
||
Philipp, can you take a look at the Identity Block design and provide guidance and feedback? Thank you.
Flags: needinfo?(philipp)
Updated•8 years ago
|
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Comment 7•7 years ago
|
||
While we might make changes here, it seems unlikely there will be any specific to this bug or the complaints voiced here, and rather more generic about how we treat the url bar, icons in it, the identity block etc., when editing URLs, and when focus is/isn't in the URL bar. As a result, closing this bug and clearing needinfo.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(philipp)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•