1231504 - Copy over APZ physics prefs from b2g to fennec and generally clean up APZ prefs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

We should copy over the b2g physics prefs to fennec to start with, and then tune it further.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Commands/output to check final pref differences

So I did this, and I also did a bunch of cleanup of the APZ prefs while I was at it. To verify my cleanup didn't change any unnexpected prefs I wrote a script [1] to preprocess the pref files and spit out the final pref values for the various platforms. That allowed me to compare the prefs before and after my change to ensure that only things that I intended to change did change.

I'm attaching the commands and output from the check. It turns out I did modify some overscroll and touch tolerance prefs for desktop as well but I decided to keep those changes since overscroll is not used on desktop and the touch tolerance should probably be the same on desktop as it is on mobile (for whenever we enable touch support).

[1] https://github.com/staktrace/moz-scripts/blob/master/allprefs.sh

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Clean up APZ prefs in all.js

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Make fennec use the same pan_repaint_interval as b2g

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 3 - Consolidate MOZ_WIDGET_GONK prefs into all.js so they apply to fennec

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 4 - Move more b2g prefs to all.js

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 5 - Copy physics prefs from b2g.js to fennec

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 6 - Update b2gdroid to also use the same prefs as b2g/fennec

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8697170 [details] [diff] [review]
Part 2 - Make fennec use the same pan_repaint_interval as b2g

Review of attachment 8697170 [details] [diff] [review]:
-----------------------------------------------------------------

Is this changing b2g's pan_repaint_interval from 16 to 250?

Comment 9

[Botond Ballo [:botond]]

Comment on attachment 8697172 [details] [diff] [review]
Part 4 - Move more b2g prefs to all.js

Review of attachment 8697172 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ +581,5 @@
>  pref("apz.minimap.enabled", false);
>  pref("apz.num_paint_duration_samples", 3);
>  pref("apz.overscroll.enabled", false);
>  pref("apz.overscroll.min_pan_distance_ratio", "1.0");
> +pref("apz.overscroll.stretch_factor", "0.35");

Alphabetize this while you're at it?

Comment 10

[Kartikaya Gupta (email:[e-mail])]

(In reply to Botond Ballo [:botond] from comment #8)
> Is this changing b2g's pan_repaint_interval from 16 to 250?

No, the default in all.js is 16 for all platforms. Previously it was overriden in all.js for b2g to 250 and then overridden back to 16 in b2g.js. This just takes out the unnecessary overriding.

(In reply to Botond Ballo [:botond] from comment #9)
> > +pref("apz.overscroll.stretch_factor", "0.35");
> 
> Alphabetize this while you're at it?

Good catch, will do

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/62996518d6fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2556ac639972
https://hg.mozilla.org/integration/mozilla-inbound/rev/b82fe31367a4
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e1e5d9dcd9f
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb8652c01ef8
https://hg.mozilla.org/integration/mozilla-inbound/rev/f37f04feb3b5

Comment 12

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4585ac9e16dd for gtest bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=18448365&repo=mozilla-inbound

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/875e5bb4244a
https://hg.mozilla.org/integration/mozilla-inbound/rev/d53f2dbcb294
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5c1bf84f25f
https://hg.mozilla.org/integration/mozilla-inbound/rev/da9ba4768e46
https://hg.mozilla.org/integration/mozilla-inbound/rev/d60addb5aedf
https://hg.mozilla.org/integration/mozilla-inbound/rev/881d7b6bda39

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/875e5bb4244a
https://hg.mozilla.org/mozilla-central/rev/d53f2dbcb294
https://hg.mozilla.org/mozilla-central/rev/b5c1bf84f25f
https://hg.mozilla.org/mozilla-central/rev/da9ba4768e46
https://hg.mozilla.org/mozilla-central/rev/d60addb5aedf
https://hg.mozilla.org/mozilla-central/rev/881d7b6bda39