1231538 - Build a ContainerLayer for position:fixed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Matt Woodrow (:mattwoodrow)]

position:fixed creates a stacking context now, so we can create a ContainerLayer for it.

This will also let us remove the code dealing with position:fixed from FrameLayerBuilder.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Build a ContainerLayer for position:fixed and background-attachment:fixed

It's not less code overall, but it removes some complexity from FrameLayerBuilder and moves it into it's own self-contained display item. I think that's worth having.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8709685 [details] [diff] [review]
Build a ContainerLayer for position:fixed and background-attachment:fixed

Review of attachment 8709685 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, much better

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c99e8abb5e00

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c99e8abb5e00

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Bug 1251527 is a pretty bad regression. Can we back this out Matt?