Closed
Bug 1231538
Opened 9 years ago
Closed 9 years ago
Build a ContainerLayer for position:fixed
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
Details
Attachments
(1 file)
|
44.91 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
position:fixed creates a stacking context now, so we can create a ContainerLayer for it.
This will also let us remove the code dealing with position:fixed from FrameLayerBuilder.
|
Assignee | |
Comment 1•9 years ago
|
||
It's not less code overall, but it removes some complexity from FrameLayerBuilder and moves it into it's own self-contained display item. I think that's worth having.
Attachment #8709685 -
Flags: review?(roc)
Comment on attachment 8709685 [details] [diff] [review]
Build a ContainerLayer for position:fixed and background-attachment:fixed
Review of attachment 8709685 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, much better
Attachment #8709685 -
Flags: review?(roc) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
|
||
Updated•9 years ago
|
Target Milestone: mozilla46 → mozilla47
Bug 1251527 is a pretty bad regression. Can we back this out Matt?
Flags: needinfo?(matt.woodrow)
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(matt.woodrow)
You need to log in
before you can comment on or make changes to this bug.
Description
•