Convert JS callsites to use asyncOpen2 within browser/components/feeds/FeedConverter.js

RESOLVED FIXED in Firefox 53

Status

()

defect
P1
normal
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment, 3 obsolete attachments)

No description provided.
Assignee: nobody → mozilla
Blocks: 1182535
Status: NEW → ASSIGNED
Summary: Convert JS callsites to use asyncOpen2 within browser/ → Convert JS callsites to use asyncOpen2 within browser/components/feeds/FeedConverter.js
Summary: Convert JS callsites to use asyncOpen2 within browser/components/feeds/FeedConverter.js → Convert JS callsites to use asyncOpen2 within browser/components/feeds
Depends on: 1105556
Most likely the right patch but we are loading TYPE_INTERNAL_IFRAME, so let's wait till docshell stuff landed before we move forward with this patch, see:

doContentSecurityCheck {
  channelURI: http://mochi.test:8888/tests/browser/components/feeds/test/bug408328-data.xml
  loadingPrincipal: SystemPrincipal
  triggeringPrincipal: SystemPrincipal
  contentPolicyType: 29
  securityMode: 0
  initalSecurityChecksDone: no
  enforceSecurity: no
}
Whiteboard: [domsecurity-active]
Depends on: 1269263
Depends on: 1182569
Still blocked on TYPE_DOCUMENT being available within nsContentSecurityManager
Actually we can land the FeedWriter changes, hence I filed Bug 1274219 leaving just the FeedConverter changes within this bug.
Summary: Convert JS callsites to use asyncOpen2 within browser/components/feeds → Convert JS callsites to use asyncOpen2 within browser/components/feeds/FeedConverter.js
Attachment #8711861 - Attachment is obsolete: true
Attachment #8747600 - Attachment is obsolete: true
This bug will land together with the changes of Bug 1182569, but I suppose it's ready for review. Thanks!
Attachment #8754298 - Attachment is obsolete: true
Attachment #8782406 - Flags: review?(gijskruitbosch+bugs)

Comment 6

3 years ago
Comment on attachment 8782406 [details] [diff] [review]
bug_1232432_feedconverter_asyncopen2.patch

Review of attachment 8782406 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8782406 - Flags: review?(gijskruitbosch+bugs) → review+
Priority: -- → P1

Comment 7

3 years ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7066ba5a48e4
Convert feeds/feedConverter to use asyncOpen2(). r=gijs

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7066ba5a48e4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.