1232432 - Convert JS callsites to use asyncOpen2 within browser/components/feeds/FeedConverter.js

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1232432_asyncopen2_browser_components_feeds.patch

Most likely the right patch but we are loading TYPE_INTERNAL_IFRAME, so let's wait till docshell stuff landed before we move forward with this patch, see:

doContentSecurityCheck {
  channelURI: http://mochi.test:8888/tests/browser/components/feeds/test/bug408328-data.xml
  loadingPrincipal: SystemPrincipal
  triggeringPrincipal: SystemPrincipal
  contentPolicyType: 29
  securityMode: 0
  initalSecurityChecksDone: no
  enforceSecurity: no
}

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1232432_asyncopen2_browser_components_feeds.patch

Still blocked on TYPE_DOCUMENT being available within nsContentSecurityManager

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Actually we can land the FeedWriter changes, hence I filed Bug 1274219 leaving just the FeedConverter changes within this bug.

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1232432_asyncopen2_feedconverter.patch

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1232432_feedconverter_asyncopen2.patch

This bug will land together with the changes of Bug 1182569, but I suppose it's ready for review. Thanks!

Comment 6

[:Gijs (he/him)]

Comment on attachment 8782406 [details] [diff] [review]
bug_1232432_feedconverter_asyncopen2.patch

Review of attachment 8782406 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7066ba5a48e4
Convert feeds/feedConverter to use asyncOpen2(). r=gijs

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7066ba5a48e4