Closed
Bug 1232727
Opened 10 years ago
Closed 10 years ago
Change variable name: WebConsoleConnectionProxy.owner
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
Attachments
(1 file)
|
10.49 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
WebConsoleConnectionProxy takes a parameter called aWebConsole. The comment says this should be a WebConsole instance. However, it is passed a WebConsoleFrame instance.
The variable needs to be renamed and the comment should be updated.
Additionally, this WCF is then assigned to WebConsoleConnectionProxy.owner. Currently, there are other objects in the file which have an owner property, where value *is* an instance of WebConsole. To avoid confusion, we should rename to be more descriptive.
See Bug #1064458
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → lclark
|
|
Assignee | |
Comment 1•10 years ago
|
||
This will apply once Bug 1232842 is committed.
Attachment #8699264 -
Flags: review?(bgrinstead)
|
||
Updated•10 years ago
|
Attachment #8699264 -
Flags: review?(bgrinstead) → review+
|
|
||
Comment 2•10 years ago
|
||
|
|
||
Comment 4•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
||
Comment 5•10 years ago
|
||
[bugday-20160323]
Status: RESOLVED,FIXED -> UNVERIFIED
Comments:
STR: Not clear.
Developer specific testing
Component:
Name Firefox
Version 46.0b9
Build ID 20160322075646
Update Channel beta
User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS Windows 7 SP1 x86_64
Expected Results:
Developer specific testing
Actual Results:
As expected
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•