1232842 - Fix aArgs in webconsole.js

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Lin Clark [:linclark]]

This will make it easier to add/edit new parameters to the file (e.g. Bug # 	1232727).

Comment 1

[Lin Clark [:linclark]]

Attachment: Bug1232842.patch

I had to change a few variable names beyond just removing the leading "a":

1. aVar -> variableObject
2. aString -> str
3. aArguments -> args
4. aURI -> uri
5. aURL -> url

I lowercased uri and url because I didn't want them to be misunderstood as constants

I also changed two declarations of callback in function bodies. I thought it was clearer to have a parameter called "callback".

Comment 2

[Brian Grinstead [:bgrins]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f54300fb9d82

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8699231 [details] [diff] [review]
Bug1232842.patch

Review of attachment 8699231 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM assuming try turns up green.  Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/797cbaa987ef

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/797cbaa987ef

Comment 6

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel	        beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected