1232985 - /bugs/321402-4|5|6.xul fail on linux64 when running from a docker container

Status: RESOLVED WONTFIX

(Taskcluster :: Services, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

we are working on getting our tests running inside of taskcluster which uses a model where we run tests in a docker container.  This is a new operating system for us in the sense that we are trying to recreate the same environment we have our existing linux64 tests running under.

With that said, we have reftest failures!   You can see them in the R1 job on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a238c213d3a&filter-searchStr=r1&selectedJob=14637552

here are the failures:
 REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/321402-4.xul | image comparison (==), max difference: 33, number of differing pixels: 1
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/321402-5.xul | image comparison (==), max difference: 33, number of differing pixels: 1
REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/bugs/321402-6.xul | image comparison (==), max difference: 33, number of differing pixels: 1 

this is 3 tests and you can see the differences in the reftest analyzer:
http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Og4ayYWjQOC4dwpC3js6Rw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

the difference is at the very end of the d and personally I cannot see any difference- this proves I am not a robot!

in the manifest file we don't have any fuzzy-if statements:
https://dxr.mozilla.org/mozilla-central/source/layout/reftests/bugs/reftest.list#415

but the test 321402-3.xul does pass for us.  That might be a good clue.

For reference we have a lot of other failures (bug 1232316, bug 1232979, bug 1232980, bug 1232981, bug 1232983) which we are working on.

Comment 1

[Armen [:armenzg]]

Should we NI for this bug? or not yet?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

I am not quite sure how to hack on this.  My knowledge of xul is limited- should we be making this fuzzy, or adjusting the test case/reference files to have proper styling or other attributes.

:dbaron, do you have any ideas here?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

ah, found out I can add style="..." to a <label>, this allows the tests to pass.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add font-size:300 to the labels to reduce fuzzy painting

taking a random stab at this.  In a previous review there was a recommendation for adding { margin: 0 } to the 'p' element.  I am not sure if we need that or if there is a reasonable equivalent here in .xul land.

I have verified this solves the problem and here is a view of what we see on 6-ref.html:
http://people.mozilla.org/~jmaher/reftest_bugs.html

while this looks blank, ensure you scroll down in the page to see everything.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8701101 [details] [diff] [review]
add font-size:300 to the labels to reduce fuzzy painting

apologies for the random requests- this approach passes on taskcluster, but fails in our existing buildbot based environment.  I will keep looking into this and if there are any suggestions I should look into doing, I will be happy to go in that direction!

Comment 6

[Armen [:armenzg]]

This is still a valid bug on m1.medium - http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/K6nmUCvqTt2zgxBViuAoxg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

with anti-aliasing turned off to match what we do on existing tests, this is now green- I recommend wontfix.

Comment 8

[Armen [:armenzg]]

Not happening anymore.

Comment 9

[Pete Moore [:pmoore][:pete]]

Moving closed bugs across to new Bugzilla product "TaskCluster".