1234764 - about:profiles, It's possible to accidentally end up with Nightly always asking for confirmation to launch default profile

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20151221030239
STR:
1. Make sure that (1) you have several profiles (2) when you start Nightly using normal shortcut,
   it launches default profile
2. Close Nightly, launch Firefox 45- with option -P
3. Select current default profile, uncheck "Use the selected profile without asking at startup"
4. Click "Start Firefox"
5. Close Firefox
6. Launch Nightly using your normal shortcut   [It'll open Brand NEW Profile Manager]
7. Click button "Set as default profile" next to the profile from Step 1 (== profile from Step 3),
   select that profile, click "Start Nightly"
8. Close Nightly
9. Launch Nightly using your normal shortcut

Result:       It opens Brand NEW Profile Manager
Expectations: It should launch the default profile

I'm leaving keyword "regressionwindow-wanted" because I can't be sure that this bug was reproducible in Brand NEW Profile Manager from the beginning (bug 1232629)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: profileE.patch

Comment 2

[(no longer active)]

Comment on attachment 8701422 [details] [diff] [review]
profileE.patch

Review of attachment 8701422 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutProfiles.js
@@ +64,5 @@
> +    });
> +
> +    let offline = document.getElementById("work-offline");
> +    offline.addEventListener('change', function() {
> +      /* Bug 257777 */

Please remove this useless comment.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a1ac3ab8cb9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a1ac3ab8cb9