1235061 - Create histogram probe to measure % of users who have disabled zoomed view

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

We have UI telemetry to tell us if people touch this pref in settings, but it would be useful to get a picture of what % of users actually have this enabled/disabled.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1235061 - Create histogram probe to measure how often users have zoomed view enabled/disabled. r=mfinkle

Review commit: https://reviewboard.mozilla.org/r/29049/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29049/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8701866 [details]
MozReview Request: Bug 1235061 - Create histogram probe to measure how often users have zoomed view enabled/disabled. r=mfinkle

https://reviewboard.mozilla.org/r/29049/#review25861

Needs a data collection peer r+ too, right?

::: mobile/android/chrome/content/browser.js:609
(Diff revision 1)
> +        Telemetry.addData("FENNEC_TRACKING_PROTECTION_STATE", parseInt(BrowserApp.getTrackingProtectionState()));

Do we care that this was inside a NIGHTLY_BUILD block?

Comment 3

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 8701866 [details]
> MozReview Request: Bug 1235061 - Create histogram probe to measure how often
> users have zoomed view enabled/disabled. r=mfinkle
> 
> https://reviewboard.mozilla.org/r/29049/#review25861
> 
> Needs a data collection peer r+ too, right?

I was assuming you could play both roles here, but I'll ask vladan to take a look as well.
 
> ::: mobile/android/chrome/content/browser.js:609
> (Diff revision 1)
> > +        Telemetry.addData("FENNEC_TRACKING_PROTECTION_STATE", parseInt(BrowserApp.getTrackingProtectionState()));
> 
> Do we care that this was inside a NIGHTLY_BUILD block?

I was being lazy by not filing a separate bug - this used to be behind a Nightly flag because it was only tracking a pref that had UI on Nightly, but that changed with bug 1228090. With that change, this probe is useful for users up to release as well, since it tells us if they disabled tp for pb as well.

Comment 4

[:Margaret Leibovic]

Comment on attachment 8701866 [details]
MozReview Request: Bug 1235061 - Create histogram probe to measure how often users have zoomed view enabled/disabled. r=mfinkle

Flagging vladan for a data collection review.

Comment 5

[Vladan Djeric (:vladan)]

Comment on attachment 8701866 [details]
MozReview Request: Bug 1235061 - Create histogram probe to measure how often users have zoomed view enabled/disabled. r=mfinkle

https://reviewboard.mozilla.org/r/29049/#review25981

Note that this will be an opt-in histogram on Release

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/9e210cee056b1a3d213198b4e38679612b0bb0bc
Bug 1235061 - Create histogram probe to measure how often users have zoomed view enabled/disabled. r=mfinkle p=vladan

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Should we track 45 where the zoomed view first appears (bug 1196146)?

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9e210cee056b

Comment 9

[:Margaret Leibovic]

Comment on attachment 8701866 [details]
MozReview Request: Bug 1235061 - Create histogram probe to measure how often users have zoomed view enabled/disabled. r=mfinkle

Approval Request Comment
[Feature/regressing bug #]: Zoomed view (shipping in Fx45).

[User impact if declined]: We don't know how many people are disabling this feature.

[Describe test coverage new/current, TreeHerder]: No automated test for probe.

[Risks and why]: Low-risk, just adds telemetry probe.

[String/UUID change made/needed]: None.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/03dd9c0b08ea

Comment 11

[Carsten Book [:Tomcat]]

had to back this out for causing failures like https://treeherder.mozilla.org/logviewer.html#?job_id=1707444&repo=mozilla-aurora 

6:52 <@mfinkle> Tomcat|sheriffduty: https://bugzilla.mozilla.org/show_bug.cgi?id=1235061#c2
06:52 < firebot> Bug 1235061 — FIXED, [e-mail] — Create histogram probe to measure % of users who have disabled zoomed view
06:52 <@mfinkle> margaret ^
06:52 <@mfinkle> turns out, moving that code out of the NIGHTLY_BUILD block is what is breaking aurora

Comment 12

[:Margaret Leibovic]

Landed an updated patch without the TP probe:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2db713b1c2fb