Closed Bug 1235089 Opened 4 years ago Closed 4 years ago

Intermittent test_ocsp_stapling.js | Test timed out

Categories

(Core :: Security: PSM, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: kats, Assigned: Cykesiopka)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1129771 +++

This intermittent failure from bug 1129771 is still happening, but mostly on B2G now. Cloning the bug rather than reopening because it's been closed for a long time and reopening it is probably going to get confusing.
This also happens on emulator-x86-kk very often, like https://treeherder.mozilla.org/#/jobs?repo=try&revision=3779955620ed.
Blocks: 1192135
Hi David,
Could you help to provide some advice on this bug?
Flags: needinfo?(dkeeler)
Well, test_ocsp_stapling.js is a long test and the emulators are slow. Either splitting the test up or upping the timeout limit should help address this.
Flags: needinfo?(dkeeler)
Priority: -- → P1
test_ocsp_stapling.js can take ~290s to run on e.g. b2g-emu-x86-kk, which is very close to the default 300s limit.
Splitting out some tests should reduce the intermittent time outs.

Review commit: https://reviewboard.mozilla.org/r/31913/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31913/
Attachment #8710957 - Flags: review?(dkeeler)
https://reviewboard.mozilla.org/r/31913/#review28661

::: security/manager/ssl/tests/unit/test_ocsp_must_staple.js:9
(Diff revision 1)
> -// things happen and bad things don't.
> +// extension is present in intermediate and end-entitie certificates.

Oops: s/end-entitie/end-entity/.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48a9b432f981
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d6eee26d1f3

b2g-emu-x86-kk goes from ~290s to ~240s, which seems good enough for now.
Presumably this will also help b2g-emu-ics, but I've long given up on that platform.
Assignee: nobody → cykesiopka.bmo
Status: NEW → ASSIGNED
Comment on attachment 8710957 [details]
MozReview Request: Bug 1235089 - Split out OCSP Must Staple tests from test_ocsp_stapling.js to avoid intermittent time outs.

https://reviewboard.mozilla.org/r/31913/#review28709

Good stuff. Hopefully this is enough separated out, but we can always split it again.

::: security/manager/ssl/tests/unit/test_ocsp_must_staple.js:26
(Diff revision 1)
>      clearSessionCache();

Are any testcases run before this point? I don't think we need to call clearSessionCache here. (Similarly, I think we can set security.ssl.enable_ocsp_must_staple directly (i.e. not in a add_test block) this first time.)

::: security/manager/ssl/tests/unit/test_ocsp_must_staple.js:40
(Diff revision 1)
>    // We disable OCSP must-staple in the next two tests so we can perform checks

I think this comment was incorrect - it should be "We disable OCSP stapling in the next two tests...", right?
https://reviewboard.mozilla.org/r/31913/#review28709

Thanks for the review.

> Are any testcases run before this point? I don't think we need to call clearSessionCache here. (Similarly, I think we can set security.ssl.enable_ocsp_must_staple directly (i.e. not in a add_test block) this first time.)

Done.

> I think this comment was incorrect - it should be "We disable OCSP stapling in the next two tests...", right?

Yes, you're correct. I'll change the comment.
Attachment #8710957 - Attachment is obsolete: true
Attachment #8711444 - Flags: review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3eaf15643f4

(The X2 failures look unrelated.)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bbfbd1e73bf1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.