1235670 - Remove lint "warning"s and fix issues

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In bug 1177781, we switched lint's default errors to warnings so we could land it in automation and not have everything break. This is the follow-up that undoes that and fixes the issues.

Comment 1

[Deepa]

Hi Michael, Sebastian,  can I take this bug up?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Hi Deepa. This bug is only about making lint report errors instead of warnings after we have fixed all lint issues. However we haven't done that yet. If you are interested in fixing some of the lint warnings then have a look at bugs blocking bug 1170283. You could also re-run lint locally and file new bugs - It might find even more now, a year later. Anyways, pick one of the other bugs if you want to. :)

Comment 3

[Teng-pao Yu [:tyu]]

With Gradle plugin 2.3 there is Baseline Support[1]

(Take a snapshot for all errors and only complain about future errors not in this snapshot)

Once we update our Gradle plugin, it could be worthy if we want to get those errors back directly.

We can make a baseline and fix those temporary ignored issues later.

[1] http://tools.android.com/tech-docs/lint-in-studio-2-3

--

Notes for current status regarding failing the builds on lint issues as of May 15, 2017, FWIW:

For the `app` component--

1. The mach build is currently not affected by the lint errors.

2. For the gradle build, only `build` task will do lint checks but not `assemble` tasks (Android default).

   For the `app` component, the lintOptions.abortOnError is enabled while there is a lint.xml changing the severity levels of erros we have not fixed yet (as described in earlier comments).

Comment 4

[Teng-pao Yu [:tyu]]

Filed Bug 1366641 to track usage of lint baseline support.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.