1366641 - Utilize lint baseline to block out long lasted unsolved lint problems

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P5)

Description

[Teng-pao Yu [:tyu]]

With Gradle plugin 2.3 there is Baseline Support[1]

(Take a snapshot for all errors and only complain about future errors not in this snapshot)

Once we update our Gradle plugin, it could be worthy if we want to get lint errors back without thorough fix on Bug 1235670.

[1] http://tools.android.com/tech-docs/lint-in-studio-2-3

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

This turns out to be frustratingly poorly implemented.  There's a "absolutePaths false" option, but it only makes paths relative to mobile/android/app (the Gradle project root) relative.  So all the paths in mobile/android/base are still absolute :(  See the patches in https://bugzilla.mozilla.org/show_bug.cgi?id=1366644 for examples.

So to use baseline, we'll need to normalize our source code, moving most of m/a/base into m/a/app.

Comment 2

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 3

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1366641 - Configure a baseline for |mach android lint|. r?agi

This is awkward.  We have many lint errors, and most of them we are
unlikely to address any time soon.  We'd like to make them part of a
lint "baseline" configuration and not think of them much again, but
the configuration files include local paths.  Therefore we do a little
work to rewrite paths to be symbolic.

This isn't maximally general: we might want to handle linting the
`geckoview` project, and we might want to handle tasks for every
Android variant; but those can follow as needed.