1236082 - Increase user identity email address display in Loop panel footer

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Chris Rafuse :crafuse]

Attachment: Current email ID Loop panel footer

Maximize email ID display within the Loop panel footer.  Maintain ellipses at the end if very long email ID is display.

Comment 1

[Chris Rafuse :crafuse]

Attachment: UID set to 40 characters output.

Set email truncate to 40 characters.

Comment 2

[Chris Rafuse :crafuse]

Attachment: UID 40 Chars with settings menu displayed

Comment 3

[GitHub Autolander Bot]

Attachment: [loop] chrafuse:bug-1236082-increase-user-identity-display > mozilla:master

Comment 4

[Chris Rafuse :crafuse]

Comment on attachment 8704435 [details] [review]
[loop] chrafuse:bug-1236082-increase-user-identity-display > mozilla:master

Increased UID email truncation from 24chars to 40chars.
Adjusted test.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8704435 [details] [review]
[loop] chrafuse:bug-1236082-increase-user-identity-display > mozilla:master

I agree with Standard8 and Mike's comments.  Can you take a run at implementing this as suggested in the PR instead?

Comment 6

[Chris Rafuse :crafuse]

Attachment: UID CSS 270px width with ellipsis

Using CSS to set width and overflow-x to be hidden and with ellipsis.
In the HTML it creates a scrollbar element that is not shown, maybe why the truncate was used.

Comment 7

[Chris Rafuse :crafuse]

Attachment: UID Footer Overflow

Removed outer containing DIV(.user-details) to overflow just the string directly in the flexed outer container(.user-identity) inside the footer.

Was there and will there be a drop down menu for user-id and/or sign up links.
Some CSS should be removed if not.

Comment 8

[Chris Rafuse :crafuse]

truncate still used:

shared/test/utils_test.js
639:  describe("#truncate", function() {
642:        var output = sharedUtils.truncate(new Array(75).join());
648:        var output = sharedUtils.truncate(new Array(73).join(), 20);
672:        var output = sharedUtils.truncate(new Array(73).join(), 20);

Will not remove util method.

Comment 9

[Ed Lee :Mardak]

If the only usage of truncate is in tests that make sure truncate is working correctly, we should be able to remove it and the tests.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8705810 [details]
UID Footer Overflow

Looking good; need some CSS changes, and then I'd like one more look...

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

The new changes have a visual problem: the email address is no longer in the same vertical line as the settings bar.

Comment 12

[Chris Rafuse :crafuse]

Attachment: UID Align and Measure

Comment 13

[Chris Rafuse :crafuse]

Attachment: UID_Margin_Inline_End.png

Comment 14

[Mark Banner (:standard8)]

Chris: If you force-push to your remote origin branch after any follow-up changes and before merging merge to master, then github will close PRs automatically for you.

Also, don't forget to close the bug ;-)

https://github.com/mozilla/loop/commit/cc3eb2e2d2f0c2af66b6cfc5df2e336ddcc4155d

Comment 15

[Ada [:adalucinet]]

Reproduced with 46.0a1 from 2015-12-30, under Windows 7 64-bit.
Verified fixed with latest Nightly 47.0a1 (from 2016-02-02), across platforms [1].

[1] Ubuntu 14.04 32-bit, Mac OS X 10.9.5, Windows 7 64-bit