Increase user identity email address display in Loop panel footer

VERIFIED FIXED

Status

Hello (Loop)
Client
P3
normal
Rank:
35
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: crafuse, Assigned: crafuse)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User Story

Display long user ID email addresses in the Loop panel footer.

Attachments

(3 attachments, 5 obsolete attachments)

(Assignee)

Description

2 years ago
Created attachment 8703188 [details]
Current email ID Loop panel footer

Maximize email ID display within the Loop panel footer.  Maintain ellipses at the end if very long email ID is display.
(Assignee)

Updated

2 years ago
Blocks: 1226607
(Assignee)

Comment 1

2 years ago
Created attachment 8704424 [details]
UID set to 40 characters output.

Set email truncate to 40 characters.
(Assignee)

Comment 2

2 years ago
Created attachment 8704432 [details]
UID 40 Chars with settings menu displayed
Created attachment 8704435 [details] [review]
[loop] chrafuse:bug-1236082-increase-user-identity-display > mozilla:master
(Assignee)

Comment 4

2 years ago
Comment on attachment 8704435 [details] [review]
[loop] chrafuse:bug-1236082-increase-user-identity-display > mozilla:master

Increased UID email truncation from 24chars to 40chars.
Adjusted test.
Attachment #8704435 - Flags: review?(edilee)
Attachment #8704435 - Flags: review?(dmose)
(Assignee)

Updated

2 years ago
Attachment #8704424 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8704432 - Attachment is obsolete: true
Comment on attachment 8704435 [details] [review]
[loop] chrafuse:bug-1236082-increase-user-identity-display > mozilla:master

I agree with Standard8 and Mike's comments.  Can you take a run at implementing this as suggested in the PR instead?
Attachment #8704435 - Flags: review?(dmose) → feedback+

Updated

2 years ago
Attachment #8704435 - Flags: review?(edilee)
(Assignee)

Comment 6

2 years ago
Created attachment 8704877 [details]
UID CSS 270px width with ellipsis

Using CSS to set width and overflow-x to be hidden and with ellipsis.
In the HTML it creates a scrollbar element that is not shown, maybe why the truncate was used.
Attachment #8704877 - Flags: review?(mdeboer)
Attachment #8704877 - Flags: review?(edilee)
(Assignee)

Updated

2 years ago
Attachment #8704435 - Flags: review?(dmose)
(Assignee)

Updated

2 years ago
Attachment #8704877 - Flags: review?(mdeboer)
Attachment #8704877 - Flags: review?(edilee)
Rank: 35
Priority: P2 → P3
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED

Updated

2 years ago
Attachment #8704435 - Flags: review?(dmose)
(Assignee)

Updated

2 years ago
Attachment #8704877 - Attachment is obsolete: true
(Assignee)

Comment 7

2 years ago
Created attachment 8705810 [details]
UID Footer Overflow

Removed outer containing DIV(.user-details) to overflow just the string directly in the flexed outer container(.user-identity) inside the footer.

Was there and will there be a drop down menu for user-id and/or sign up links.
Some CSS should be removed if not.
Attachment #8705810 - Flags: review?(dmose)
(Assignee)

Comment 8

2 years ago
truncate still used:

shared/test/utils_test.js
639:  describe("#truncate", function() {
642:        var output = sharedUtils.truncate(new Array(75).join());
648:        var output = sharedUtils.truncate(new Array(73).join(), 20);
672:        var output = sharedUtils.truncate(new Array(73).join(), 20);

Will not remove util method.

Comment 9

2 years ago
If the only usage of truncate is in tests that make sure truncate is working correctly, we should be able to remove it and the tests.
Comment on attachment 8705810 [details]
UID Footer Overflow

Looking good; need some CSS changes, and then I'd like one more look...
Attachment #8705810 - Flags: review?(dmose)
The new changes have a visual problem: the email address is no longer in the same vertical line as the settings bar.
(Assignee)

Comment 12

2 years ago
Created attachment 8706600 [details]
UID Align and Measure
Attachment #8706600 - Flags: review?(dmose)
(Assignee)

Updated

2 years ago
Attachment #8706600 - Attachment is obsolete: true
Attachment #8706600 - Flags: review?(dmose)
(Assignee)

Updated

2 years ago
Attachment #8705810 - Attachment is obsolete: true
(Assignee)

Comment 13

2 years ago
Created attachment 8706697 [details]
UID_Margin_Inline_End.png
Attachment #8706697 - Flags: ui-review?(sfranks)
Attachment #8706697 - Flags: ui-review?(b.pmm)
Attachment #8706697 - Flags: ui-review?(sfranks)
Attachment #8706697 - Flags: ui-review?(b.pmm)
Attachment #8706697 - Flags: ui-review+
(Assignee)

Updated

2 years ago
Attachment #8704435 - Flags: review?(dmose)

Updated

2 years ago
Attachment #8704435 - Flags: review?(dmose) → review+
Chris: If you force-push to your remote origin branch after any follow-up changes and before merging merge to master, then github will close PRs automatically for you.

Also, don't forget to close the bug ;-)

https://github.com/mozilla/loop/commit/cc3eb2e2d2f0c2af66b6cfc5df2e336ddcc4155d
Status: ASSIGNED → RESOLVED
Iteration: --- → 46.3 - Jan 25
Last Resolved: 2 years ago
Resolution: --- → FIXED
Flags: qe-verify+
QA Contact: bogdan.maris

Comment 15

2 years ago
Reproduced with 46.0a1 from 2015-12-30, under Windows 7 64-bit.
Verified fixed with latest Nightly 47.0a1 (from 2016-02-02), across platforms [1].

[1] Ubuntu 14.04 32-bit, Mac OS X 10.9.5, Windows 7 64-bit
Status: RESOLVED → VERIFIED
Flags: qe-verify+

Updated

2 years ago
Blocks: 1249552
You need to log in before you can comment on or make changes to this bug.