1236231 - [experiment] Make sure the Tracking Protection tour doorhanger is not shown when the tour starts from about:privatebrowsing

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[:Paolo Amadini]

(In reply to Alex Gibson [:agibson] from bug 1233773 comment #4)
> I should also note a slight regression I noticed here when launching the
> tracking protection tour on step 1. Because the first use of TP might also
> be when someone launches the tour in a private window, this change results
> in a slight flicker on the first door-hanger appearing. I'm guessing because
> it is launched via the product, and then again straight after via the tour
> page loading. Everything still work ok, but we might want to add an
> exception here?

We can do either or both of these:
- Add a way for the UITour to tell Firefox that the tour has started.
- Record this when the tour button in private windows is pressed.

Comment 1

[Alex Gibson [:agibson]]

Would it not be simpler just to not invoke the door-hanger in product if the current active tab is TP tour URL? We should try and avoid adding more things to UITour just to cover edge cases.

Comment 2

[:Paolo Amadini]

This is not necessarily an edge case, because it happens every time a user's first interaction with Tracking Protection (after enabling the preference) is from a private window.

Detecting the URL is not necessarily easy, as it may vary with locale or after redirects, that's why I suggested using an explicit command from the page. On the other hand, by the time the code in the page runs, it may be too late to prevent the first doorhanger from showing, so the indication would have to be provided in advance by whatever button on mozilla.org starts the tour. In the end, maybe the URL detection is better even if more complicated.

Comment 3

[Alex Gibson [:agibson]]

(In reply to :Paolo Amadini from comment #2)
> This is not necessarily an edge case, because it happens every time a user's
> first interaction with Tracking Protection (after enabling the preference)
> is from a private window.
> 
> Detecting the URL is not necessarily easy, as it may vary with locale or
> after redirects, that's why I suggested using an explicit command from the
> page. On the other hand, by the time the code in the page runs, it may be
> too late to prevent the first doorhanger from showing, so the indication
> would have to be provided in advance by whatever button on mozilla.org
> starts the tour. In the end, maybe the URL detection is better even if more
> complicated.

Yeah, I'm seeing the in-product triggered door-hanger appearing before the JS on the mozorg page is running. On slower network connections, this may be even more apparent. Also, the tour is not started via a button on mozorg itself, it's started by a blue CTA button on the in-product new private-browsing tab.

Comment 4

[:Paolo Amadini]

(In reply to Alex Gibson [:agibson] from comment #3)
> Also, the tour is not started via a button on mozorg
> itself, it's started by a blue CTA button on the in-product new
> private-browsing tab.

Don't we have a way to start the tour from the first-run page or the page that talks about privacy features anymore?

Comment 5

[Alex Gibson [:agibson]]

(In reply to :Paolo Amadini from comment #4)
> (In reply to Alex Gibson [:agibson] from comment #3)
> > Also, the tour is not started via a button on mozorg
> > itself, it's started by a blue CTA button on the in-product new
> > private-browsing tab.
> 
> Don't we have a way to start the tour from the first-run page or the page
> that talks about privacy features anymore?

All we currently do is prompt the user to open a new private window, for example on: https://www.mozilla.org/en-US/firefox/private-browsing/

It is up to the user to initiate the TP tour once they open a private window.

Comment 6

[:Paolo Amadini]

(In reply to Alex Gibson [:agibson] from comment #5)
> All we currently do is prompt the user to open a new private window, for
> example on: https://www.mozilla.org/en-US/firefox/private-browsing/

Cool! So instrumenting the tour button in product will practically cover all cases, and may be all we need to do.

Comment 7

[Alex Gibson [:agibson]]

(In reply to :Paolo Amadini from comment #6)
> (In reply to Alex Gibson [:agibson] from comment #5)
> > All we currently do is prompt the user to open a new private window, for
> > example on: https://www.mozilla.org/en-US/firefox/private-browsing/
> 
> Cool! So instrumenting the tour button in product will practically cover all
> cases, and may be all we need to do.

That sounds good to me - I guess there could be a gray area where someone does link to the tour directly for some reason, but hopefully this will be enough of an edge case.

Comment 8

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1236231 - Make sure the Tracking Protection tour doorhanger is not shown when the tour starts from about:privatebrowsing. r=past

Review commit: https://reviewboard.mozilla.org/r/30325/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30325/

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8706372 [details]
MozReview Request: Bug 1236231 - Make sure the Tracking Protection tour doorhanger is not shown when the tour starts from about:privatebrowsing. r=past

https://reviewboard.mozilla.org/r/30325/#review27291

Looks good to me.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/166f314b7d4d

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/166f314b7d4d

Comment 12

[Paul Silaghi, QA [:pauly]]

Question:
If TP="Only in private windows" => opening cnn.com in a private window doesn't show the tour
If TP="Always" => opening cnn.com in a private window shows the tour
Is this correct?

Comment 13

[:Paolo Amadini]

(In reply to Paul Silaghi, QA [:pauly] from comment #12)
> Question:
> If TP="Only in private windows" => opening cnn.com in a private window
> doesn't show the tour
> If TP="Always" => opening cnn.com in a private window shows the tour
> Is this correct?

Yes, this is correct.

Comment 14

[Paul Silaghi, QA [:pauly]]

Verified fixed 47.0a1 (2016-02-03) Win 7, Ubuntu 14.04, OS X 10.10.5