Closed Bug 1231757 Opened 9 years ago Closed 8 years ago

[experiment] Notification on First Activation of Tracking Protection in Normal Mode

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Iteration:
47.1 - Feb 8
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: MarcoM, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy][strings])

User Story

Summary:
* As a user, I want to understand why the page I'm on has an unusual layout so that I have confidence that Firefox is working 

Acceptance Criteria: 

* A doorhanger displays from the Shield icon on the *first time* that TP activates (blocks loads on a page) after user has turned on TP globally
* After the user has seen the shield and either clicked through or dismissed it, they do not see it again
* Doorhanger has an "X" where a user can dismiss the notification permanently
* Doorhanger text, (COPY NOT FINAL): Title: "How Tracking Protection works" body: "When you see the shield, Firefox is blocking some parts of the page that could track your browsing activity."
* Clicking "Next" goes to *step 2* of the UI tour: https://www.mozilla.org/en-US/firefox/45.0a1/tracking-protection/start/?step=2

Attachments

(3 files)

TP_doorhanger_notification.jpg
127.71 KB, image/jpeg
Details
MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past
58 bytes, text/x-review-board-request
past
: review+
Details
Screenshot
207.28 KB, image/png
Details 
      No description provided.
Flags: qe-verify+
Whiteboard: [fxprivacy] → [fxprivacy] [strings]
User Story: (updated)
Whiteboard: [fxprivacy] [strings] → [fxprivacy]
Whiteboard: [fxprivacy] → [fxprivacy][strings]
Priority: P1 → P2
Priority: P2 → P1
Summary: Notification on First Activation of Tracking Protection in Normal Mode → [experiment] Notification on First Activation of Tracking Protection in Normal Mode
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 46.1 - Dec 28
Depends on: 1231785
Most of this has been already implemented in bug 1177162. Improvements:
 - Always show the doorhanger until the user clicks the "X" or starts the tour
 - Update the strings to match the final copy of Step 1 of the current UI tour
 - Point to Step 2 of a tour that does not mention Private Browsing in its contents
 - Close the tab and return to previous page instead of restarting the tour when finished
Depends on: 1177162
Whiteboard: [fxprivacy][strings] → [fxprivacy][strings][blocked]
Iteration: 46.1 - Dec 28 → ---
Depends on: 1233771
Depends on: 1233773
Temporarily reduced in priority to 'P2' until dependencies are resolved.
Status: ASSIGNED → NEW
Priority: P1 → P2
Depends on: 1236229
Depends on: 1236231
Comment on attachment 8703345 [details]
MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29345/diff/1-2/
The latest version should address all the notes from comment 2.
Attached image Screenshot — 
This is a screenshot of the updated doorhanger in context.
Comment on attachment 8703345 [details]
MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29345/diff/2-3/
Attachment #8703345 - Attachment description: MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. → MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past
Attachment #8703345 - Flags: review?(past)
This is still blocked on bug 1233771 and bug 1233773, but we might as well review the patch.
Comment on attachment 8703345 [details]
MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29345/diff/3-4/
Comment on attachment 8703345 [details]
MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past

https://reviewboard.mozilla.org/r/29345/#review27529

Everything looks good to me, apart from the question below.

::: browser/base/content/browser-trackingprotection.js:7
(Diff revision 4)
> +  MAX_INTROS: 20,

Does this mean that users who only use TP in PBM will now have to see the doorhanger 20 times?
Attachment #8703345 - Flags: review?(past) → review+
Assignee: paolo.mozmail → nobody
Priority: P2 → P4
Comment on attachment 8703345 [details]
MozReview Request: Bug 1231757 - Notification on first activation of Tracking Protection in normal mode. r=past

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29345/diff/4-5/
(In reply to Panos Astithas [:past] from comment #11)
> Does this mean that users who only use TP in PBM will now have to see the
> doorhanger 20 times?

If the user does not interact with the doorhanger but closes it by clicking outside, it is displayed again when you navigate, reload the page, or switch back to the tab. If the doorhanger is ignored for 20 times, then we don't display it anymore. It's a fallback because we expect the user to take the tour or close the message using the "X" icon after a few times it is displayed. A value of 10 tended to make the doorhanger disappear too early during my testing, while 20 seems to work better.
I've also made sure in the latest version of the patch that the code to display the doorhanger is not invoked at all if you use Tracking Protection in private windows only, preserving the current state of not changing any persistent preference that's not linked to an obvious UI control.
I'll land this patch soon in order to have the strings in the tree, but with the doorhanger disabled until the tour update from bug 1233773 is ready.
I thought I had already pushed this after the tryserver build succeeded, but I didn't.

Looking forward to the autoland feature with automatic tryserver failure classification :-)
Blocks: 1242525
Whiteboard: [fxprivacy][strings][blocked] → [fxprivacy][strings]
https://hg.mozilla.org/mozilla-central/rev/0b913b279cb6
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Assignee: nobody → paolo.mozmail
Iteration: --- → 47.1 - Feb 8
Priority: P4 → P1
QA Contact: paul.silaghi
<<* A doorhanger displays from the Shield icon on the *first time* that TP activates (blocks loads on a page) after user has turned on TP globally>>
I don't see anything in 47.0a1 (2016-01-27). Here is what I did:
1. start FF with a new profile
2. set TP to 'always'
3. open cnn.com
Do I need to setup a staging server or something?
Flags: needinfo?(paolo.mozmail)
Sorry, this is still disabled until bug 1242525 lands.
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(paolo.mozmail)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: