1238095 - [TRACKING] Stop using CPOWs in Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

There are two places where I see Marionette getting references to CPOWs:

https://dxr.mozilla.org/mozilla-central/rev/d4213241bb796fdfa7a5ad4f1989e97b44474364/testing/marionette/driver.js#2208

and

https://dxr.mozilla.org/mozilla-central/rev/d4213241bb796fdfa7a5ad4f1989e97b44474364/testing/marionette/proxy.js#134

As we start to outlaw CPOWs in non-addon code, this is going to eventually break because these CPOWs are going to end up going through Task.jsm and Promise-backend.jsm, which will cause the throw-ings.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Bug 1149998 might be related to this considering https://dxr.mozilla.org/mozilla-central/rev/d4213241bb796fdfa7a5ad4f1989e97b44474364/testing/marionette/driver.js#2221.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Bug 1153828 could take care of the second case.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I have seen a different warning yesterday in our Travis run for firefox-ui-tests which seem to be Marionette related:

https://travis-ci.org/mozilla/firefox-ui-tests/jobs/105258229#L1612

> Marionette threw an error: Error: unsafe CPOW usage forbidden
> error.isError@chrome://marionette/content/error.js:53:12
> error.isWebDriverError@chrome://marionette/content/error.js:61:10

Comment 4

[Andreas Tolfsen ❲:ato❳]

We are basically read to disable the pref that disables CPOW checks now, but because bug 1244425 and its dependents could be hard to uplift we might not be able to until the patches ride all the trains.  This is because the Marionette client is being used for Firefox upgrade tests, which means it needs to function against Stable, Aurora, and Beta.

I will investigate further by requesting uplifts of bug 1244425 and bug 1280947.

Comment 5

[Andreas Tolfsen ❲:ato❳]

As of https://bugzilla.mozilla.org/show_bug.cgi?id=1323253, unsafe CPOW checks are enabled on central.  We will let the patches associated with it also ride the trains.