1238115 - Inaccurate localization comments after bug 1203563

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Plewako [:stef]]

"Easily switch between open pages with tabs." and "Personalize things like your default search engine in Settings." strings have inaccurate localization comments.

https://github.com/mozilla/firefox-ios/commit/b5ada405354710ea33d35c919e9dfa201f43fa44

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8717020 [details] [review]
PR

See PR for comments.

Comment 3

[Stefan Plewako [:stef]]

This was not fixed for sure.

Comment 4

[Bryan Munar (:bkmunar)]

Attachment: PR

how are these?

Comment 5

[Stefan Plewako [:stef]]

Comment on attachment 8718145 [details] [review]
PR

I see similarly sounding strings on the screenshot behind http://mzl.la/1QsprBp
(why link shortener btw) but it is hard to say (without checking the code) whenever strings got changed or they are completely different thing.

It is better to describe UI element where translated string will be displayed. For example "Description on the introduction tour carousel slide" or "String spoken by assistive technology (like VoiceOver) stating on which page of the intro wizard we currently are. E.g. Introductory slide 1 of 3" or "Title on the introduction tour carousel slide". Screenshots are great when accurate but tend to become outdated easily.

Comment 6

[Francesco Lodolo [:flod]]

Can some summarize the current status of this bug? Which strings need a different comment, and if the current assignee is going to drive it to a conclusion?

Comment 7

[Francesco Lodolo [:flod]]

As far as I can tell this changeset should have fixed the remaining issues
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f