Inaccurate localization comments after bug 1203563

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: stef, Assigned: bkmunar)

Tracking

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios+)

Details

Attachments

(2 attachments)

PR
48 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review | Splinter Review
PR
48 bytes, text/x-github-pull-request
bkmunar
: review?
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
"Easily switch between open pages with tabs." and "Personalize things like your default search engine in Settings." strings have inaccurate localization comments.

https://github.com/mozilla/firefox-ios/commit/b5ada405354710ea33d35c919e9dfa201f43fa44

Updated

2 years ago
tracking-fxios: --- → ?
Rank: 100
tracking-fxios: ? → +
(Reporter)

Updated

2 years ago
Blocks: 1242542
(Assignee)

Updated

2 years ago
Assignee: nobody → bmunar
(Assignee)

Comment 1

2 years ago
Created attachment 8717020 [details] [review]
PR
Attachment #8717020 - Flags: review?(jhugman)
Comment on attachment 8717020 [details] [review]
PR

See PR for comments.
Attachment #8717020 - Flags: review?(jhugman) → review+
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

2 years ago
This was not fixed for sure.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

2 years ago
Created attachment 8718145 [details] [review]
PR

how are these?
Attachment #8718145 - Flags: review?(splewako)
(Reporter)

Comment 5

2 years ago
Comment on attachment 8718145 [details] [review]
PR

I see similarly sounding strings on the screenshot behind http://mzl.la/1QsprBp
(why link shortener btw) but it is hard to say (without checking the code) whenever strings got changed or they are completely different thing.

It is better to describe UI element where translated string will be displayed. For example "Description on the introduction tour carousel slide" or "String spoken by assistive technology (like VoiceOver) stating on which page of the intro wizard we currently are. E.g. Introductory slide 1 of 3" or "Title on the introduction tour carousel slide". Screenshots are great when accurate but tend to become outdated easily.
Attachment #8718145 - Flags: review?(splewako) → review?
Blocks: 1256395
(Reporter)

Updated

2 years ago
Blocks: 1264283
Can some summarize the current status of this bug? Which strings need a different comment, and if the current assignee is going to drive it to a conclusion?
Blocks: 1277326
As far as I can tell this changeset should have fixed the remaining issues
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.