Closed Bug 1203563 Opened 9 years ago Closed 9 years ago

Add two additional first-run tour panels

Categories

(Firefox for iOS :: General, defect)

Other
iOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Tracking Status
fxios 1.1+ ---

People

(Reporter: krudnitski, Assigned: jhugman)

References

Details

Attachments

(2 files)

Can we look at adding two additional first-run tour panels. Same design / feel will be used as the others with no call to action. They should be inserted prior to the last slide (so would be slides 3 and 4 out of a 5-slide tour). Slide 3: bring the user's attention to the 'share extension' action, allowing users to view URLs later in Firefox or send a tab to another Firefox. Slide 4: suggest that if the user loves Firefox, to drag it to the home dock. It's such a simple action that totally doesn't make you 'forget about it'. Granted it's manual, but hopefully the power of suggestion may help guide some to not forget about us. Copy and designs will be needed. Matej - you'll be called upon for your creative wisdom here, no doubt. Very strongly desired for 1.1, and string freeze is around the corner.
Flags: needinfo?(alam)
Suggested copy: 3 Title: "Share to Firefox" 3 Body: "Send your favorite links to Firefox using the iOS share sheet" 4 Title: "Make it your browser" 4 Body: "Tap and hold the Firefox icon and move it into your dock for easy access"
Flags: needinfo?(matej)
(In reply to Darrin Henein [:darrin] from comment #1) > Suggested copy: > > 3 Title: "Share to Firefox" > 3 Body: "Send your favorite links to Firefox using the iOS share sheet" Is "share sheet" something that the average iOS user will understand? I think I know what it refers to, but I didn't know it was called that. I'm also not sure about "Share to Firefox." Maybe it could be one of the following: 3 Title: "Send to Firefox" 3 Body: "Use the iOS share sheet to send links from other apps" 3 Title: "Send to Firefox" 3 Body: "Use the iOS share sheet to open links from other apps in Firefox" > 4 Title: "Make it your browser" > 4 Body: "Tap and hold the Firefox icon and move it into your dock for easy > access" This one feels a bit long. Here are two other options: 4 Title: "Make it your browser" 4 Body: "Tap, hold and move the Firefox icon into your dock for easy access" 4 Title: "Quick, easy access" 4 Body: "Tap, hold and move the Firefox icon into your dock"
Flags: needinfo?(matej)
Whiteboard: [needs strings]
Thanks Matej! Lets go with: 3 Title: "Send to Firefox" 3 Body: "Use the share sheet to send links from other apps to Firefox" 4 Title: "Make it your browser" 4 Body: "Tap, hold and move the Firefox icon into your dock for easy access" I will pre-land these strings for localization.
Based on the conversation in bug 1203560, we'd like to update the titles here to be one word each. Here are some options for each: 3 Title: "Share" or "Send" or "Connect" 3 Body: "Use the share sheet to send links from other apps to Firefox" 4 Title: "Choose" or "Move" or "Simplify" 4 Body: "Tap, hold and move the Firefox icon into your dock for easy access"
Thanks Matej! See attachment for current mocks and how the copy is being displayed. Thoughts?
Flags: needinfo?(alam) → needinfo?(dhenein)
^ note, i've updated the copy with what was in https://github.com/mozilla/firefox-ios/pull/1069 since posting that.
This looks great. Thanks.
Do we want some indication of the [^] share icon on the Share page (this is what most apps will use to show this sheet)...
Flags: needinfo?(dhenein) → needinfo?(alam)
Thanks guys! moving this discussion to bug 1203557
Flags: needinfo?(alam)
Depends on: 1205973
"Easily switch between open pages with tabs." and "Personalize things like your default search engine in Settings." strings have inaccurate localization comments.
Blocks: 1206901
Strings landed.
Whiteboard: [needs strings]
Assignee: dhenein → jhugman
Status: NEW → ASSIGNED
Are the assets ready for this? If so, where they be?
Flags: needinfo?(dhenein)
Ready for merge: https://github.com/mozilla/firefox-ios/pull/1121 Note – the assets in the catalog are named in the order we created them, not the order they may appear in the tour. Please reference the mockup in this bug for the correct ordering of the slides.
Flags: needinfo?(dhenein)
Attached file Pull request
Renamed the imagesets, and string identifiers. Added extra cards into slider.
Attachment #8669902 - Flags: ui-review?(dhenein)
Attachment #8669902 - Flags: review?(sleroux)
Comment on attachment 8669902 [details] [review] Pull request Code looks good except the sign in button doesn't work. Probably because we need to update this page number to be 4 instead of 2: https://github.com/mozilla/firefox-ios/blob/jhugman/Bug1203563-AddTwoFirstRunTourPanels/Client/Frontend/Intro/IntroViewController.swift#L334
Attachment #8669902 - Flags: review?(sleroux) → review+
Amended PR to fix signin bug. Good spot :sleroux
Comment on attachment 8669902 [details] [review] Pull request Beautiful, looks awesome! Thanks James :)
Attachment #8669902 - Flags: ui-review?(dhenein) → ui-review+
Merged
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verifying as fixed on Beta 1111.
Status: RESOLVED → VERIFIED
Depends on: 1238115
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: