Closed
Bug 1203563
Opened 9 years ago
Closed 9 years ago
Add two additional first-run tour panels
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fxios | 1.1+ | --- |
People
(Reporter: krudnitski, Assigned: jhugman)
References
Details
Attachments
(2 files)
47.73 KB,
image/png
|
Details | |
48 bytes,
text/x-github-pull-request
|
sleroux
:
review+
dhenein
:
ui-review+
|
Details | Review |
Can we look at adding two additional first-run tour panels. Same design / feel will be used as the others with no call to action.
They should be inserted prior to the last slide (so would be slides 3 and 4 out of a 5-slide tour).
Slide 3: bring the user's attention to the 'share extension' action, allowing users to view URLs later in Firefox or send a tab to another Firefox.
Slide 4: suggest that if the user loves Firefox, to drag it to the home dock. It's such a simple action that totally doesn't make you 'forget about it'. Granted it's manual, but hopefully the power of suggestion may help guide some to not forget about us.
Copy and designs will be needed. Matej - you'll be called upon for your creative wisdom here, no doubt. Very strongly desired for 1.1, and string freeze is around the corner.
Updated•9 years ago
|
Updated•9 years ago
|
Flags: needinfo?(alam)
Comment 1•9 years ago
|
||
Suggested copy:
3 Title: "Share to Firefox"
3 Body: "Send your favorite links to Firefox using the iOS share sheet"
4 Title: "Make it your browser"
4 Body: "Tap and hold the Firefox icon and move it into your dock for easy access"
Flags: needinfo?(matej)
Comment 2•9 years ago
|
||
(In reply to Darrin Henein [:darrin] from comment #1)
> Suggested copy:
>
> 3 Title: "Share to Firefox"
> 3 Body: "Send your favorite links to Firefox using the iOS share sheet"
Is "share sheet" something that the average iOS user will understand? I think I know what it refers to, but I didn't know it was called that.
I'm also not sure about "Share to Firefox." Maybe it could be one of the following:
3 Title: "Send to Firefox"
3 Body: "Use the iOS share sheet to send links from other apps"
3 Title: "Send to Firefox"
3 Body: "Use the iOS share sheet to open links from other apps in Firefox"
> 4 Title: "Make it your browser"
> 4 Body: "Tap and hold the Firefox icon and move it into your dock for easy
> access"
This one feels a bit long. Here are two other options:
4 Title: "Make it your browser"
4 Body: "Tap, hold and move the Firefox icon into your dock for easy access"
4 Title: "Quick, easy access"
4 Body: "Tap, hold and move the Firefox icon into your dock"
Flags: needinfo?(matej)
Updated•9 years ago
|
Whiteboard: [needs strings]
Comment 3•9 years ago
|
||
Thanks Matej! Lets go with:
3 Title: "Send to Firefox"
3 Body: "Use the share sheet to send links from other apps to Firefox"
4 Title: "Make it your browser"
4 Body: "Tap, hold and move the Firefox icon into your dock for easy access"
I will pre-land these strings for localization.
Comment 4•9 years ago
|
||
Pre-landing here https://github.com/mozilla/firefox-ios/pull/1069
Comment 5•9 years ago
|
||
Based on the conversation in bug 1203560, we'd like to update the titles here to be one word each. Here are some options for each:
3 Title: "Share" or "Send" or "Connect"
3 Body: "Use the share sheet to send links from other apps to Firefox"
4 Title: "Choose" or "Move" or "Simplify"
4 Body: "Tap, hold and move the Firefox icon into your dock for easy access"
Comment 6•9 years ago
|
||
Thanks Matej!
See attachment for current mocks and how the copy is being displayed.
Thoughts?
Flags: needinfo?(alam) → needinfo?(dhenein)
Comment 7•9 years ago
|
||
^ note, i've updated the copy with what was in https://github.com/mozilla/firefox-ios/pull/1069 since posting that.
Comment 8•9 years ago
|
||
This looks great. Thanks.
Comment 9•9 years ago
|
||
Do we want some indication of the [^] share icon on the Share page (this is what most apps will use to show this sheet)...
Flags: needinfo?(dhenein) → needinfo?(alam)
Comment 11•9 years ago
|
||
"Easily switch between open pages with tabs." and "Personalize things like your default search engine in Settings." strings have inaccurate localization comments.
Assignee | ||
Updated•9 years ago
|
Assignee: dhenein → jhugman
Status: NEW → ASSIGNED
Assignee | ||
Comment 13•9 years ago
|
||
Are the assets ready for this? If so, where they be?
Flags: needinfo?(dhenein)
Comment 14•9 years ago
|
||
Ready for merge: https://github.com/mozilla/firefox-ios/pull/1121
Note – the assets in the catalog are named in the order we created them, not the order they may appear in the tour. Please reference the mockup in this bug for the correct ordering of the slides.
Flags: needinfo?(dhenein)
Assignee | ||
Comment 15•9 years ago
|
||
Renamed the imagesets, and string identifiers. Added extra cards into slider.
Attachment #8669902 -
Flags: ui-review?(dhenein)
Attachment #8669902 -
Flags: review?(sleroux)
Comment 16•9 years ago
|
||
Comment on attachment 8669902 [details] [review]
Pull request
Code looks good except the sign in button doesn't work. Probably because we need to update this page number to be 4 instead of 2:
https://github.com/mozilla/firefox-ios/blob/jhugman/Bug1203563-AddTwoFirstRunTourPanels/Client/Frontend/Intro/IntroViewController.swift#L334
Attachment #8669902 -
Flags: review?(sleroux) → review+
Assignee | ||
Comment 17•9 years ago
|
||
Amended PR to fix signin bug. Good spot :sleroux
Comment 18•9 years ago
|
||
Comment on attachment 8669902 [details] [review]
Pull request
Beautiful, looks awesome! Thanks James :)
Attachment #8669902 -
Flags: ui-review?(dhenein) → ui-review+
Assignee | ||
Comment 19•9 years ago
|
||
Merged
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•