Closed Bug 1238118 Opened 8 years ago Closed 8 years ago

Inaccurate localization comments for "Sync Your Devices."

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal
Rank:
100

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: stef, Assigned: bmunar)

References

Details

Attachments

(2 files)

PR
48 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review
PR
48 bytes, text/x-github-pull-request
bmunar
: review?
Details | Review 
"Sync Your Devices." string has inaccurate localization comment.

https://github.com/mozilla/firefox-ios/commit/c33428e03c063b02179ae56151beae93bf0e53ff
Rank: 100
tracking-fxios: ? → +
Blocks: 1242542
Assignee: nobody → bmunar
Attached file PR — 

        Attachment #8717021 -
        Flags: review?(jhugman)

    
    

    
  
Comment on attachment 8717021 [details] [review]
PR

See PR for comments.

        Attachment #8717021 -
        Flags: review?(jhugman) → review+

    
  
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

    
    

    
  
This was not fixed for sure.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        PR
        — 
      

    


  
how are these?

        Attachment #8718146 -
        Flags: review?(splewako)

    
    

    
  
Comment on attachment 8718146 [details] [review]
PR

Do you see "Sync Your Devices." on the screenshot behind http://mzl.la/1QsprBp (why link shortener btw)?

It is better to describe UI element where translated string will be displayed. For example "Description on the introduction tour carousel slide" or "String spoken by assistive technology (like VoiceOver) stating on which page of the intro wizard we currently are. E.g. Introductory slide 1 of 3" or "Title on the introduction tour carousel slide". Screenshots are great when accurate but tend to become outdated easily.

        Attachment #8718146 -
        Flags: review?(splewako) → review?
Blocks: 1256395

    
  
Blocks: 1264283

    
    

    
  
Same question here: can someone summarize the current status of this bug? Which strings need a different comment, and if the current assignee is going to drive it to a conclusion?
Blocks: 1277326

    
    

    
  
As far as I can tell this changeset should have fixed the remaining issues
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: