Inaccurate localization comments for "Sync Your Devices."

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: stef, Assigned: bmunar)

Tracking

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios+)

Details

Attachments

(2 attachments)

PR
48 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review | Splinter Review
PR
48 bytes, text/x-github-pull-request
bmunar
: review?
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
"Sync Your Devices." string has inaccurate localization comment.

https://github.com/mozilla/firefox-ios/commit/c33428e03c063b02179ae56151beae93bf0e53ff
tracking-fxios: --- → ?
Rank: 100
tracking-fxios: ? → +
(Reporter)

Updated

3 years ago
Blocks: 1242542
(Assignee)

Updated

3 years ago
Assignee: nobody → bmunar
(Assignee)

Comment 1

3 years ago
Created attachment 8717021 [details] [review]
PR
Attachment #8717021 - Flags: review?(jhugman)
Comment on attachment 8717021 [details] [review]
PR

See PR for comments.
Attachment #8717021 - Flags: review?(jhugman) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

3 years ago
This was not fixed for sure.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

3 years ago
Created attachment 8718146 [details] [review]
PR

how are these?
Attachment #8718146 - Flags: review?(splewako)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8718146 [details] [review]
PR

Do you see "Sync Your Devices." on the screenshot behind http://mzl.la/1QsprBp (why link shortener btw)?

It is better to describe UI element where translated string will be displayed. For example "Description on the introduction tour carousel slide" or "String spoken by assistive technology (like VoiceOver) stating on which page of the intro wizard we currently are. E.g. Introductory slide 1 of 3" or "Title on the introduction tour carousel slide". Screenshots are great when accurate but tend to become outdated easily.
Attachment #8718146 - Flags: review?(splewako) → review?
Blocks: 1256395
(Reporter)

Updated

3 years ago
Blocks: 1264283
Same question here: can someone summarize the current status of this bug? Which strings need a different comment, and if the current assignee is going to drive it to a conclusion?
Blocks: 1277326
As far as I can tell this changeset should have fixed the remaining issues
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.