https://github.com/mozilla/firefox-ios/commit/41d169085981290258a732fb122eba77021e062c exposed (see https://github.com/splewako/firefox-ios-l10n-en/commit/4d77cae74ea45822f40c61c66be5f7b449a8e572) bunch of l10n notes and at least two need rewording ("Cancel alert view", "Cancel title from search engine picker").
https://github.com/mozilla/firefox-ios/commit/41d169085981290258a732fb122eba77021e062c doesn't look like the right URL. Would using "Cancel button label" for all these strings work?
(In reply to Francesco Lodolo [:flod] from comment #1) > Would using "Cancel button label" for all these strings work? Depends what "Cancel alert view" and "Cancel title from search engine picker" mean.
(In reply to Stefan Plewako [:stef] from comment #2) > Depends what "Cancel alert view" and "Cancel title from search engine > picker" mean. Brian, can you help? They were introduce in https://github.com/mozilla/firefox-ios/commit/a96a366fc8b6d93297561fdb8fb4da692fb57c1b https://github.com/mozilla/firefox-ios/commit/baaaf5d7cf6c08a6eff0d4371b7677636f8d8d9b The last being yours. My understanding is that this is always a "Cancel" button in the title, so having one common localization comment would make more sense.
These NSLocalizedStrings are both very old. The first was added back in April 2015: https://github.com/mozilla/firefox-ios/commit/c0917abc#diff-6d1fb0cf203fcd3c299d4ba3f07f21deR379 The second was added back in September 2015: https://github.com/mozilla/firefox-ios/commit/6eb78d27624fbcd116a03cc9ca5a25650fd11246#diff-fe5b509f2f2711fd2f65d15260b97d3fR20 The commits linked in comment 3 changed the code around these strings, but the NSLocalizedStrings themselves weren't touched. I agree that we should update the comments for these. We should go through and do an audit, because there are probably a lot more strings that need updating, too.
Comments were unified in https://github.com/mozilla/firefox-ios/commit/540782100fc1dd0787b632b2850ce7a8c6ac227e