1238368 - Can't click on some items on Android with Talkback enabled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nolan Darilek]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151229124331
Firefox for Android

Steps to reproduce:

1. On Android 5.1.1 with Talkback enabled, launch Firefox 43.
2. Visit https://oasis.sandstorm.io/demo.
3. Double-tap the "Try a quick demo" button.


Actual results:

Nothing


Expected results:

The button should be clicked.

I've experienced this issue throughout Sandstorm. It happens in my installed instance so isn't just limited to this, but this is the quickest reproduction.

Firefox 42.0.2 works fine on this and other pages, so this regression seems to have emerged in 43.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Eitan, seems like an accessibility regression - do you have cycles to look into this?

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Re-introduce workaround for Android tap gesture.

This may need to be back-ported to other versions.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8706556 [details] [diff] [review]
Re-introduce workaround for Android tap gesture.

Review of attachment 8706556 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works on latest android, thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72f6f6c5b98b

Comment 6

[Marco Zehe (:MarcoZ)]

[Tracking Requested - why for this release]: Major regression in interaction between TalkBack and Firefox for Android in Android 6.

Eitan, please request to land this on aurora (46) and Beta (45), since this was already a problem in 43 and 44. Thanks!

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8706556 [details] [diff] [review]
Re-introduce workaround for Android tap gesture.

Approval Request Comment
[Feature/regressing bug #]: 1238368
[User impact if declined]: Screen reader users won't be able to activate many links and buttons.
[Describe test coverage new/current, TreeHerder]: No specific treeherder tests were introduced. This was tested on Android Marshmallow devices.
[Risks and why]: This bug is bad enough that it is worth the risk of any (doubtful) regression from this fix. It only affects screen reader users who are a small fraction of the userbase.
[String/UUID change made/needed]: None.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Tracking to make sure it lands.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72f6f6c5b98b

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8706556 [details] [diff] [review]
Re-introduce workaround for Android tap gesture.

Fix for screen reader tap gesture, ok to uplift to beta and aurora.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7a134529b9b6

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5a35ba8d1c0

Comment 13

[u421692]

Verified as fixed on Firefox 45 Beta 9, on Lenovo Yoga Tablet 2 (Android 4.4.2). 
Nolan, can you please that this is fixed on your device, after updating to Firefox 45 Beta 9?