1238522 - Intermittently, the speech synthesis doesn't start after changing the Pitch

Status: VERIFIED FIXED

(Core :: Web Speech, defect)

Description

[Camelia Badau [:cbadau], Desktop QA]

Reproducible on latest Aurora 45.0a2 (buildID: ) 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Reproducible on latest Nightly 46.0a1 (buildID: 20160110030214) 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0

Steps to reproduce: 
1. Ensure that the speech synthesis is enabled (media.webspeech.synth.enabled must be true)
2. Go to http://eeejay.github.io/webspeechdemos/ . 
3. Click the "Speak it" button. 
4. After several seconds, clik the "Cancel" button. 
5. Modify the Pitch. 
6. Click the "Speak it" button. 

Actual results: Nothing happens by pressing on the "Speak it" button. The "Speak it" button doesn't work anymore and speech synthesis doesn't start. 

Expected results: Speech synthesis correctly start. 

Notes: 
1. The issue is NOT reproducible on Ubuntu 13.10 32bit and Mac OSX 10.9.5. 
2. To fix the problem, I need to close the page (http://eeejay.github.io/webspeechdemos/) and restart the browser.

Comment 1

[Camelia Badau [:cbadau], Desktop QA]

I forgot to mention the buildID for latest Aurora 45.0a2: 20160110004009.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Confirmed on Win10.

Comment 3

[Eitan Isaacson [:eeejay]]

Can you reproduce this on Windows?

Comment 4

[Makoto Kato [:m_kato]]

Take this.   Maybe, end event isn't dispatched.

Comment 5

[Makoto Kato [:m_kato]]

2 issues.

- When nsISpeechService.Speak() returns error, this item into task queue isn't removed because no DispatchError.  This issue is all platform on indirect service.  I filed as bug 1239946.
- SAPI's Speak method sometimes throws error when modifying pitch.  We should investigate this bug.

Comment 6

[Makoto Kato [:m_kato]]

Ah, I misunderstand SAPI's XML.  absmiddle doesn't allow float type.  Fix is coming.

Comment 7

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1238522 - Don't use float type for absmiddle attirubte. r?eeejay

SAPI's absmiddle attibute doesn't allow float type.  Example, when pitch was 0.75, abmiddle was -2.5.  So ISpVoice.Speak() will return error.

Review commit: https://reviewboard.mozilla.org/r/52399/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52399/

Comment 8

[Eitan Isaacson [:eeejay]]

Comment on attachment 8752046 [details]
MozReview Request: Bug 1238522 - Don't use float type for absmiddle attirubte. r?eeejay

https://reviewboard.mozilla.org/r/52399/#review50050

Sorry for the late review!

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f3cacd2c75

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5f3cacd2c75

Comment 11

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit using latest Nightly 49.0a1 (buildID: 20160520030251).