1238533 - Clicker UI notification UI

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Comment 1

[Manuel Casas Barrado [:mancas]]

Hey Romain I think this bug shouldn't be a [meta]. From my point of view a meta should describe a feature in this case something like "Link Clicker UI/ Improve Link Clicker UI" with dependency on the bugs that are part of the feature (Link Clicker Notification, Top Bar...)

WDYT?

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: WIP

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Screen Shot 2016-02-15 at 11.10.34.png

Comment 4

[Romain Testard [:RT]]

(In reply to Manuel Casas Barrado [:mancas] from comment #1)
> Hey Romain I think this bug shouldn't be a [meta]. From my point of view a
> meta should describe a feature in this case something like "Link Clicker UI/
> Improve Link Clicker UI" with dependency on the bugs that are part of the
> feature (Link Clicker Notification, Top Bar...)
> 
> WDYT?

Agreed, removed the meta tag.

Comment 5

[Manuel Casas Barrado [:mancas]]

(Commenting on User Story)
> Implement clicker UI notification per visual spec (see URL):
> - Implement UI with title, description and context tile
> - Implement custom versions of text and description text based on the
> following scenarios:
> --- Your friend didn't join yet (move tile)
> --- Your friend paused sharing

This case will be addressed in bug 1245147

> --- Your friend has left
> --- You have left

If we left the room, we need to include the "join" button somewhere because we should be able to rejoin the room. So there is any visuals about that feature?

Comment 6

[Mark Banner (:standard8)]

(In reply to Manuel Casas Barrado [:mancas] from comment #5)
> (Commenting on User Story)
> > Implement clicker UI notification per visual spec (see URL):
> > - Implement UI with title, description and context tile
> > - Implement custom versions of text and description text based on the
> > following scenarios:
> > --- Your friend didn't join yet (move tile)
> > --- Your friend paused sharing
> 
> This case will be addressed in bug 1245147

Adding dependency for reference

(In reply to Manuel Casas Barrado [:mancas] from comment #5)
> (Commenting on User Story)
> > --- Your friend has left

Note: For the entry in text chat, this is implemented in bug 1240516/bug 1240517 one of which has a patch on already.

Comment 7

[Sevaan Franks [:sevaan]]

(In reply to Manuel Casas Barrado [:mancas] from comment #5)

> If we left the room, we need to include the "join" button somewhere because
> we should be able to rejoin the room. So there is any visuals about that
> feature?

Pau has them in his designs: http://people.mozilla.org/~sfranks/Hello/Firefox%20Hello%20Link%20Clicker.png
Specifically: http://i.sevaan.com/0Z1Y0C2f0K45
And for users not using Firefox: http://i.sevaan.com/3o1X2S2e203d

Comment 8

[Sevaan Franks [:sevaan]]

> Note: For the entry in text chat, this is implemented in bug 1240516/bug
> 1240517 one of which has a patch on already.

To clarify, the chat history message about leaving, and the UI in the Link Clicker are both necessary. The chat history message is more looking ahead to when we have persistent chat history and we want to log comings and goings.

Comment 9

[Manuel Casas Barrado [:mancas]]

Attachment: Room_ready

Comment 10

[Manuel Casas Barrado [:mancas]]

Attachment: media_permissions

Comment 11

[Manuel Casas Barrado [:mancas]]

Attachment: clicker_in_the_room

Comment 12

[Manuel Casas Barrado [:mancas]]

Attachment: Generator_left

Comment 13

[Manuel Casas Barrado [:mancas]]

Attachment: clicker_left_firefox

Comment 14

[Manuel Casas Barrado [:mancas]]

Attachment: clicker_left_non_firefox

Comment 15

[Pau Masiá [:Pau]]

Comment on attachment 8720229 [details]
clicker_left_non_firefox

Color of the line beneath the Rejoin button is #CECECE?¿

Comment 16

[Manuel Casas Barrado [:mancas]]

Attachment: clicker_left_non_firefox

Comment 17

[Manuel Casas Barrado [:mancas]]

Attachment: Patch

Comment 18

[David Critchley (:dcritch)]

Comment on attachment 8720326 [details] [review]
Patch

Please see comments in github

Comment 19

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8720326 [details] [review]
Patch

Sorry Dave, now the PR is complete

Comment 20

[David Critchley (:dcritch)]

Comment on attachment 8720326 [details] [review]
Patch

looks good

Comment 21

[Manuel Casas Barrado [:mancas]]

Landed in master: https://github.com/mozilla/loop/commit/b74284f4cf9244ca65347c2f1404a66a141659fe