"You have disconnected" and "Rejoin" are hard-coded on the standalone UI

RESOLVED FIXED

Status

Hello (Loop)
Client
P1
normal
Rank:
1
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
STR:

1) Set you browser to a non-English language (e.g. set preference "intl.accept_languages" to "fr")
2) Get a link to a Hello room
3) Join the conversation and accept camera/mic prompt
4) Exit the conversation

Actual Results:

"You have disconnected" and "Rejoin" are not localised

Expected Results:

They are localised.


The strings are hard-coded in the document rather than being translatable.
(Assignee)

Updated

2 years ago
Rank: 1

Comment 1

2 years ago
Created attachment 8738681 [details] [review]
[loop] Standard8:bug-1262568-l10n > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8738681 - Flags: review?(edilee)
Attachment #8738681 - Flags: review?(dcritchley)
Attachment #8738681 - Flags: review?(edilee)
Attachment #8738681 - Flags: review?(dcritchley)
Attachment #8738681 - Flags: review+
(Assignee)

Comment 2

2 years ago
Forgot to mention this as a regression from bug 1238533.
Blocks: 1238533
Keywords: regression
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla/loop/commit/5606f911d4de6af7afdcc3bacf31682032ffb76e
Status: NEW → RESOLVED
Iteration: --- → 48.3 - Apr 18
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1265865
You need to log in before you can comment on or make changes to this bug.