Closed
Bug 1262568
Opened 8 years ago
Closed 8 years ago
"You have disconnected" and "Rejoin" are hard-coded on the standalone UI
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
Iteration:
48.3 - Apr 25
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
STR: 1) Set you browser to a non-English language (e.g. set preference "intl.accept_languages" to "fr") 2) Get a link to a Hello room 3) Join the conversation and accept camera/mic prompt 4) Exit the conversation Actual Results: "You have disconnected" and "Rejoin" are not localised Expected Results: They are localised. The strings are hard-coded in the document rather than being translatable.
Assignee | ||
Updated•8 years ago
|
Rank: 1
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8738681 -
Flags: review?(edilee)
Attachment #8738681 -
Flags: review?(dcritchley)
Updated•8 years ago
|
Attachment #8738681 -
Flags: review?(edilee)
Attachment #8738681 -
Flags: review?(dcritchley)
Attachment #8738681 -
Flags: review+
Assignee | ||
Comment 2•8 years ago
|
||
Forgot to mention this as a regression from bug 1238533.
Blocks: 1238533
Keywords: regression
Assignee | ||
Comment 3•8 years ago
|
||
https://github.com/mozilla/loop/commit/5606f911d4de6af7afdcc3bacf31682032ffb76e
Status: NEW → RESOLVED
Iteration: --- → 48.3 - Apr 18
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•