Closed Bug 1262821 Opened 7 years ago Closed 7 years ago

After exiting a conversation, selecting to "Download Firefox" actually rejoins the conversation

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Iteration:
48.3 - Apr 25

People

(Reporter: standard8, Assigned: mancas)

References

Details

Attachments

(2 files)

STR:

- Using latest code (or 1.2.x branch), get a link to a room.
- Open it in Google Chrome
- Join the room, accept camera/microphone if necessary
- Leave the room.
- Click the Download Firefox button

Actual results:

The room is rejoined.

Expected results:

A page to download Firefox is displayed.
Rank: 1
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
Attachment #8739355 - Flags: review?(dcritchley)
Attachment #8739355 - Flags: review?(crafuse)
Attachment #8739355 - Flags: review?(standard8)
Attachment #8739355 - Flags: review?(fernando.campo)
Attachment #8739355 - Flags: review?(edilee)
Comment on attachment 8739355 [details] [review]
[loop] mancas:bug1262821 > mozilla:master

small code change, but I'd recommend to ask for ux-review for the visuals
Attachment #8739355 - Flags: review?(standard8)
Attachment #8739355 - Flags: review?(fernando.campo)
Attachment #8739355 - Flags: review?(edilee)
Attachment #8739355 - Flags: review?(dcritchley)
Attachment #8739355 - Flags: review?(crafuse)
Attachment #8739355 - Flags: review+
Attached image hover state
Attachment #8739913 - Flags: ui-review?(b.pmm)
Attachment #8739913 - Flags: ui-review?(b.pmm) → ui-review+
https://github.com/mozilla/loop/commit/e2d706b670544fbeb77c66ca6be22980ae61b617
Status: ASSIGNED → RESOLVED
Iteration: --- → 48.3 - Apr 25
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1265865
You need to log in before you can comment on or make changes to this bug.