1241723 - Update WebKitCSSMatrix.idl to match spec updates (optional args that default to 0)

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Mike Taylor [:miketaylr]]

The spec was missing optional args that default to 0 for the following methods:
skewX, skewY, rotateAxisAngle, translate


The Spec IDL has been updated: https://compat.spec.whatwg.org/#webkitcssmatrix-interface

Comment 1

[Mike Taylor [:miketaylr]]

Attachment: Update WebKitCSSMatrix.idl to match latest spec updates.

The following methods have been updated to match WebKit's behavior,
taking optional arguments that default to 0:

rotateAxisAngle()
skewX()
skewY()
translate()

Comment 2

[Mike Taylor [:miketaylr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab134f3a4e2a

Comment 3

[Mike Taylor [:miketaylr]]

Thanks for the review!

Comment 4

[Mike Taylor [:miketaylr]]

Try looks good (some unrelated timeouts), will land when inbound is green.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cbf2adc7b07

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4cbf2adc7b07

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4cbf2adc7b07

Comment 8

[Mike Taylor [:miketaylr]]

Comment on attachment 8710795 [details] [diff] [review]
Update WebKitCSSMatrix.idl to match latest spec updates.

Approval Request Comment
[Feature/regressing bug #]:
Feature is Bug 717722. The known regressions are Bug 1241786 and Bug 1242333.

When I wrote the spec I wasn't aware that web content depended on calling certain methods with default args -- sites broke and now we know.

[User impact if declined]:
Aurora/Dev Edition users will have a few high-profile broken sites. :(
(Google Photos and Google Plus, probably more we don't know about)

[Describe test coverage new/current, TreeHerder]:
Try run in comments.

[Risks and why]: 
Low risks. This change just adds default argument values to 4 WebKitCSSMatrix methods in the webidl.



[String/UUID change made/needed]:
None (no UUIDs are involved in webidl, right?)

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8710795 [details] [diff] [review]
Update WebKitCSSMatrix.idl to match latest spec updates.

More web compat fixes, affects popular sites. Please uplift to aurora.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/64907bda21b3