1241875 - crash in mozilla::layers::TextureClient::Destroy

Status: RESOLVED DUPLICATE of bug 1242448

(Core :: Graphics, defect)

Description

[Ada [:adalucinet]]

This bug was filed from the Socorro interface and is 
report bp-06dff31b-e1d6-4789-8bbb-7c2e32160122.
=============================================================
Affected builds:
* latest Aurora 45.0a2 e10s disabled
* latest Nightly 46.0a1 e10s disabled

Unaffected builds:
* 44 beta 9
* 44.0RC, both builds 1 & 2

Affected OS: Mac OS X 10.10.5

Steps to reproduce: same as in bug 1241484 comment 0

Additional notes: 
1. With e10s enabled (both 45 and 46), some black artifacts are displayed; please see this screen recording ⇒ https://goo.gl/9ceaoP
2. More reports: https://crash-stats.mozilla.com/signature/?signature=mozilla%3A%3Alayers%3A%3ATextureClient%3A%3ADestroy&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1#reports

Comment 1

[u279076]

Based on 6 months of crash data this started in Firefox 45.0a1 20151202030210:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=66a6d7ec9534b9d7847b665142fef0dd87623768&tochange=470f4f8c2b2d6f82e56e161a4b05262c85f55b59

Alexandra, can you please confirm?

Comment 2

[u279076]

Nical, I suspect this might have something to do with bug 1200595.

Comment 3

[Nicolas Silva [:nical]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #2)
> Nical, I suspect this might have something to do with bug 1200595.

This is a shutdown problem where a texture is kept alive too late. The fact that it reproduces on osx and not linux hints that it might be related to tiling (with the texture pool mechanism that may be retaining textures during shutdown, perhaps).

I am working on a patch in bug 1242448 that should (hopefully) fix this problem.

Comment 4

[Ada [:adalucinet]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #1)
> Based on 6 months of crash data this started in Firefox 45.0a1
> 20151202030210:
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=66a6d7ec9534b9d7847b665142fef0dd87623768&tochange=470f
> 4f8c2b2d6f82e56e161a4b05262c85f55b59
> 
> Alexandra, can you please confirm?

Both 45.0a1 builds from 2015-12-01 and 2015-12-02 crash, but with different signatures

After further investigation I got the same range as in bug 1241861:
Last good Nightly: 2015-06-05 - no crash
First bad Nightly: 2015-06-06 - bp-89cd6ab4-7f23-42b2-982d-955562160201 which is bug 1217128, but the crashing thread is almost identical

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0496b5b3e9ef&tochange=4a07e1ac3cdf

Also reproducible with latest Nightly 47.0a1: bp-1622bde4-7c97-4e1f-9e25-c09642160201; not reproducible with hardware acceleration off.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

There is also bug 1250954

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Did the patch from bug 1242448, mentioned in comment 3, fix the problem?

Comment 8

[Ada [:adalucinet]]

(In reply to Milan Sreckovic [:milan] from comment #7)
> Did the patch from bug 1242448, mentioned in comment 3, fix the problem?

The crash is no longer reproducible with latest Aurora 48.0a2 nor with Nightly 49.0a1, under Mac OS X 10.10.5

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

Getting this DUPE off the regression triage list.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'mozilla::layers::TextureClient::Destroy':
 - nightly (version 50): 0 crash from 2016-06-06.
 - aurora  (version 49): 0 crash from 2016-06-07.
 - beta    (version 48): 170 crashes from 2016-06-06.
 - release (version 47): 1230 crashes from 2016-05-31.
 - esr     (version 45): 285 crashes from 2016-04-07.

Crash volume on the last weeks:
             Week N-1   Week N-2   Week N-3   Week N-4   Week N-5   Week N-6   Week N-7
 - nightly          0          0          0          0          0          0          0
 - aurora           0          0          0          0          0          0          0
 - beta            26         16         21         30         28         25         13
 - release        207        159        191        194        188        173         39
 - esr             38         24         22         34         28         20         11

Affected platforms: Windows, Mac OS X