1242073 - Design issues with new about:networking design

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: screenshot1.png

Images can say more than a thousand words.

Comment 1

[Sören Hentzschel]

Attachment: screenshot2.png

Comment 2

[Sören Hentzschel]

Also the rows should have some top/bottom padding. Please have a look at the in content preferences, for example the list of installed search engines or the application pane. The height of the rows should be the same.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

(In reply to Sören Hentzschel from comment #0)
> Created attachment 8711214 [details]
> Images can say more than a thousand words.

The line is intentional. It's supposed to separate the stats section (above), and the diagnostics section (below), which hasn't landed yet (bug 907050)

Comment 4

[magicp]

Attachment: VirtualBox_Mac OS X (64 bit)_23_01_2016_19_36_20.png

On Mac OS X 10.6.8 Snow Leopard, no left margin and the warning image.

Comment 5

[Tim Nguyen :ntim]

Attachment: about-networking-improved

Comment 6

[Tim Nguyen :ntim]

https://hg.mozilla.org/integration/fx-team/rev/97fafd23a077adacc2141c66cf372260cba61e7e
Bug 1242073 - Tweaks to about:networking. r=jaws

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/97fafd23a077

Comment 8

[Sören Hentzschel]

The alignment issue you can see in the second screenshot was not addressed with this patch. Shall I file a new ticket or was it intentional not to change the warning page?

Comment 9

[Tim Nguyen :ntim]

(In reply to Sören Hentzschel from comment #8)
> The alignment issue you can see in the second screenshot was not addressed
> with this patch. Shall I file a new ticket or was it intentional not to
> change the warning page?

The spacing is intentional, I've reduced it in this bug so it looks less out of place.

Comment 10

[Sören Hentzschel]

But it's not consistent with about:config. Is there a reason for this style difference?

Comment 11

[Tim Nguyen :ntim]

(In reply to Sören Hentzschel from comment #10)
> But it's not consistent with about:config. Is there a reason for this style
> difference?

about:config's warning screen has a description, about:networking doesn't. Consider the spacing as a replacement for the description :)

Comment 12

[Tim Nguyen :ntim]

Attachment: followup: clean up aboutNetworking CSS

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8716763 [details] [diff] [review]
followup: clean up aboutNetworking CSS

Review of attachment 8716763 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a new bug for the follow-up, as the patches in this bug have already landed and it's been more than 24 hours since it was merged to mozilla-central. I'd rather not have one bug that has patches that span multiple Nightly builds, as it can make looking for regressions confusing.

r+ once you file a new bug for this and associate the patch with the new bug number. You can reference this comment in the new bug and carry-forward the r+.

Comment 14

[Sören Hentzschel]

(In reply to Tim Nguyen [:ntim] (mostly busy until Feb. 12th) from comment #11)
> (In reply to Sören Hentzschel from comment #10)
> > But it's not consistent with about:config. Is there a reason for this style
> > difference?
> 
> about:config's warning screen has a description, about:networking doesn't.
> Consider the spacing as a replacement for the description :)

Spacing is no replacement for a description. Even it is intentional, it looks like a style bug.

Comment 15

[Tim Nguyen :ntim]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #13)
> Comment on attachment 8716763 [details] [diff] [review]
> followup: clean up aboutNetworking CSS
> 
> Review of attachment 8716763 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please file a new bug for the follow-up, as the patches in this bug have
> already landed and it's been more than 24 hours since it was merged to
> mozilla-central. I'd rather not have one bug that has patches that span
> multiple Nightly builds, as it can make looking for regressions confusing.
> 
> r+ once you file a new bug for this and associate the patch with the new bug
> number. You can reference this comment in the new bug and carry-forward the
> r+.

Thanks for the review ! Moved this to bug 1246498.

Comment 16

[Tim Nguyen :ntim]

Attachment: about-networking-no-spacing.png

Sören, removing the spacing doesn't look great either (too much negative spacing around the warning). Perhaps, we should consider adding a description to about:networking's warning instead ?

Comment 17

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, a description would be best. Valentin, can you file a bug to add a description and include what you think it should say?

Comment 18

[Saheda Reza [:Antora]]

I have reproduced this bug according to (2016-1-22)

It's fixed on Latest Developer Edition -- Build ID (20160408004012), User Agent: Mozilla/5.0 (Windows NT 6.3; rv:47.0) Gecko/20100101 Firefox/47.0

Tested OS-- Windows8.1 32bit

Comment 19

[Jared Wein [:jaws] (please needinfo? me)]

I filed bug 1324792 for the description text.