1242562 - downloaded file size isn't rounded

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[DRW]

Attachment: 46.0a1.png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0 Cyberfox/43.0.4
Build ID: 20160107105516

Steps to reproduce:

download a file


Actual results:

size displayed has many decimal places


Expected results:

size should be rounded like on desktop

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Confirmed. A test page is https://getfedora.org/en/workstation/download/ this seems like a good mentor bug. I think modifying https://dxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutDownloads.js#332 should do the trick.

Comment 3

[Jan Henning [:JanH]]

I can reproduce this on the emulator (API 22).

Comment 4

[Jan Henning [:JanH]]

Attachment: MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

Currently, download sizes on Fennec aren't rounded for locales using a "." as their decimal separator.

Review commit: https://reviewboard.mozilla.org/r/51277/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51277/

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8750009 [details]
MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

https://reviewboard.mozilla.org/r/51277/#review48331

thank you!

Comment 6

[Jan Henning [:JanH]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cd1a28c9f53&selectedJob=20513433

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7f5cb264eb70

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f5cb264eb70

Comment 9

[Sorina Florean [:sflorean]]

Attachment: file_size_nightly_49.png

Verified as fixed in build 49.0a1 2016-05-12;
Device: LG G4 (Android 5.1).

Comment 10

[Jan Henning [:JanH]]

Comment on attachment 8750009 [details]
MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

Approval Request Comment
[Feature/regressing bug #]: Download manager on Android
[User impact if declined]: Locales using a "." decimal separator (e.g. English) will display download sizes with excessively many decimal places, especially now that bug 1218317 has been fixed in 48 (previously, file sizes for finished downloads stopped displaying after a browser restart).
[Describe test coverage new/current, TreeHerder]: some time on Nightly/Aurora
[Risks and why]: Very low, this just a trivial change so that rounding of the download size doesn't depend on the current decimal separator being used.
[String/UUID change made/needed]: none

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8750009 [details]
MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

This fixes a UI issue. Take it in 48 beta 7. The fixes should be in fennec 48 beta 8.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03fad0a46c36

Comment 13

[Sorina Florean [:sflorean]]

Verified as fixed in Firefox for Android 48.0 RC;
Device: Nexus 5 (Android 6.0.1).

Comment 14

[Stefan Deiac]

Remove the qe-verify flag based on comment 13.