Closed Bug 1242562 Opened 4 years ago Closed 4 years ago

downloaded file size isn't rounded

Categories

(Firefox for Android :: Download Manager, defect)

46 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 49
Tracking Status
firefox44 --- wontfix
firefox45 --- wontfix
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- verified
firefox49 --- verified

People

(Reporter: phoenixuk06, Assigned: JanH)

References

Details

Attachments

(3 files)

Attached image 46.0a1.png
User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0 Cyberfox/43.0.4
Build ID: 20160107105516

Steps to reproduce:

download a file


Actual results:

size displayed has many decimal places


Expected results:

size should be rounded like on desktop
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 1270429
Assignee: nobody → jh+bugzilla
I can reproduce this on the emulator (API 22).
Currently, download sizes on Fennec aren't rounded for locales using a "." as their decimal separator.

Review commit: https://reviewboard.mozilla.org/r/51277/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51277/
Attachment #8750009 - Flags: review?(mak77)
Comment on attachment 8750009 [details]
MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

https://reviewboard.mozilla.org/r/51277/#review48331

thank you!
Attachment #8750009 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/7f5cb264eb70
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Verified as fixed in build 49.0a1 2016-05-12;
Device: LG G4 (Android 5.1).
Comment on attachment 8750009 [details]
MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

Approval Request Comment
[Feature/regressing bug #]: Download manager on Android
[User impact if declined]: Locales using a "." decimal separator (e.g. English) will display download sizes with excessively many decimal places, especially now that bug 1218317 has been fixed in 48 (previously, file sizes for finished downloads stopped displaying after a browser restart).
[Describe test coverage new/current, TreeHerder]: some time on Nightly/Aurora
[Risks and why]: Very low, this just a trivial change so that rounding of the download size doesn't depend on the current decimal separator being used.
[String/UUID change made/needed]: none
Attachment #8750009 - Flags: approval-mozilla-beta?
Comment on attachment 8750009 [details]
MozReview Request: Bug 1242562 - Byte count rounding shouldn't depend on the decimal separator used. r=mak

This fixes a UI issue. Take it in 48 beta 7. The fixes should be in fennec 48 beta 8.
Attachment #8750009 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Verified as fixed in Firefox for Android 48.0 RC;
Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Remove the qe-verify flag based on comment 13.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.