1242594 - textTracks lost when video removed from DOM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Paul Sayre]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36

Steps to reproduce:

I loaded a HTML doc with a <track> inside a <video>. I removed the video element from the DOM, then added it back.

Test case: http://jsfiddle.net/4efxr61w/5/


Actual results:

The video.textTracks.length === 0 after the video is removed from the DOM.


Expected results:

The video.textTracks should contain the child <track> element.

Comment 1

[Paul Sayre]

After a little digging, this may also be related these:

Bug 1206304 - Created text tracks don't appear in the textTracks list
https://bugzilla.mozilla.org/show_bug.cgi?id=1206304

Bug 1097279 - HTML5 video tracks without src aren't counted. Lose count after wrap.
https://bugzilla.mozilla.org/show_bug.cgi?id=1097279

Comment 2

[Benjamin Chen [:bechen]]

See
https://dxr.mozilla.org/mozilla-central/source/dom/html/HTMLTrackElement.cpp#277

Comment 3

[Gary Katsevman]

I'm experiencing the same thing. For video.js, I tried to enable native text track support but I'm unable to do so because video.js wraps the video element in a div so all tracks that are available when video.js initializes are lost due to this bug.

Here's my test case: http://plnkr.co/edit/xmG766?p=preview

Comment 4

[Benjamin Chen [:bechen]]

Attachment: MozReview Request: Bug 1242594 - Don't remove the textTrack if it's parent is not null. r=rillian

Review commit: https://reviewboard.mozilla.org/r/48943/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48943/

Comment 5

[Benjamin Chen [:bechen]]

Attachment: MozReview Request: Bug 1242594 - Add testcase. r=rillian

Review commit: https://reviewboard.mozilla.org/r/48945/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48945/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8745234 [details]
MozReview Request: Bug 1242594 - Don't remove the textTrack if it's parent is not null. r=rillian

https://reviewboard.mozilla.org/r/48943/#review46347

Comment 7

[Ralph Giles (:rillian)]

Comment on attachment 8745235 [details]
MozReview Request: Bug 1242594 - Add testcase. r=rillian

https://reviewboard.mozilla.org/r/48945/#review46349

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbbac91d2aff
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e66690c2448

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bbbac91d2aff
https://hg.mozilla.org/mozilla-central/rev/3e66690c2448