1242893 - Change the import-globals-from eslint custom rule to also register properties added to the top-level `this` in JSM modules as globals

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Lint and Formatting, defect, P4)

Description

[Patrick Brosset <:pbro>]

TIL: JSM modules that need to work on b2g too need to export their globals on `this`.

So, for instance, in \devtools\client\framework\ToolboxProcess.jsm there are these 2 lines:

this.EXPORTED_SYMBOLS = ["BrowserToolboxProcess"];
this.BrowserToolboxProcess = function BrowserToolboxProcess(...

The import-from-globals eslint rule
https://dxr.mozilla.org/mozilla-central/source/testing/eslint-plugin-mozilla/lib/rules/import-globals-from.js
is useful in many cases where you don't want to manually manage a list of globals in an eslint /*globals */ comment, but unfortunately, it doesn't well with these JSM modules.

Comment 1

[Tom Tromey :tromey]

Bug 1231963 is related.
I think there's a general problem where these "helper rules" aren't run when
trying to compute the globals of a file.
See bug 1242584 for another example.

Comment 2

[Mark Banner (:standard8)]

In bug 1440284 we've moved away from using this.*, so I believe this is now a wontfix.