Closed
Bug 1243857
Opened 8 years ago
Closed 8 years ago
Enable full-duplex cubeb backends for Desktop
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox47 | --- | affected |
backlog | webrtc/webaudio+ |
People
(Reporter: jesup, Assigned: jesup)
References
Details
Attachments
(2 files)
Bug for enabling all of the full-duplex backends; leave open until they're all preffed on.
Assignee | ||
Updated•8 years ago
|
Rank: 15
Assignee | ||
Updated•8 years ago
|
Component: Audio/Video: cubeb → WebRTC: Audio/Video
Assignee | ||
Updated•8 years ago
|
backlog: --- → webrtc/webaudio+
Assignee | ||
Comment 2•8 years ago
|
||
Backed out for bc and devtools failures as seen in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=22f3ea5449d7
Updated•8 years ago
|
Rank: 15 → 10
Updated•8 years ago
|
Rank: 10 → 7
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/affd6e75efcc
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43227/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43227/
Attachment #8736339 -
Flags: review?(rjesup)
Comment 7•8 years ago
|
||
Comment on attachment 8736339 [details] MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43227/diff/1-2/
Attachment #8736339 -
Attachment description: MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup → MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup
Comment 8•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43229/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/43229/
Attachment #8736343 -
Flags: review?(rjesup)
Comment 9•8 years ago
|
||
Comment on attachment 8736339 [details] MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43227/diff/2-3/
Comment 10•8 years ago
|
||
Comment on attachment 8736343 [details] MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43229/diff/1-2/
Comment 17•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3016dc350c6d https://hg.mozilla.org/integration/mozilla-inbound/rev/7f2f44eaea09
I backed out the Windows side for crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=26153254&repo=mozilla-inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/4236b0313ce3 OSX's patch is still in.
Flags: needinfo?(rjesup)
Assignee | ||
Comment 19•8 years ago
|
||
padenot: please take a look at https://treeherder.mozilla.org/logviewer.html#?job_id=26153254&repo=mozilla-inbound
Flags: needinfo?(rjesup) → needinfo?(padenot)
Comment 20•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7f2f44eaea09
Comment 24•8 years ago
|
||
Clearing NI, the windows issue has been dealt with. Only OpenSL left now !
Flags: needinfo?(padenot)
Comment 25•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a81573e42b84 https://hg.mozilla.org/mozilla-central/rev/3131a9f5a82f
Comment 26•8 years ago
|
||
I think it makes sense to scope this bug to enabling full duplex on Desktop. I'll file a new bug to enable full duplex on Android.
Summary: Enable full-duplex cubeb backends → Enable full-duplex cubeb backends for Desktop
Comment 27•8 years ago
|
||
All full-duplex cubeb backends for Desktop have pref'd on.
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: leave-open
Resolution: --- → FIXED
See Also: → 1267915
Updated•8 years ago
|
Target Milestone: --- → mozilla48
Assignee | ||
Updated•8 years ago
|
Attachment #8736339 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 28•8 years ago
|
||
Comment on attachment 8736339 [details] MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup https://reviewboard.mozilla.org/r/43227/#review46207
Assignee | ||
Updated•8 years ago
|
Attachment #8736343 -
Flags: review?(rjesup)
Assignee | ||
Comment 29•8 years ago
|
||
Comment on attachment 8736343 [details] MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup https://reviewboard.mozilla.org/r/43229/#review46209
Assignee | ||
Comment 30•8 years ago
|
||
Comment on attachment 8736343 [details] MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup https://reviewboard.mozilla.org/r/43229/#review46211
Attachment #8736343 -
Flags: review+
Updated•8 years ago
|
Target Milestone: mozilla48 → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•