Enable full-duplex cubeb backends for Desktop

RESOLVED FIXED in mozilla49

Status

()

Core
WebRTC: Audio/Video
P1
normal
Rank:
7
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Bug for enabling all of the full-duplex backends; leave open until they're all preffed on.
(Assignee)

Updated

2 years ago
Rank: 15
(Assignee)

Updated

2 years ago
Component: Audio/Video: cubeb → WebRTC: Audio/Video
(Assignee)

Updated

2 years ago
backlog: --- → webrtc/webaudio+

Comment 1

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/38335c435a45
(Assignee)

Updated

2 years ago
Blocks: 1142613
(Assignee)

Comment 2

2 years ago
Backed out for bc and devtools failures as seen in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=22f3ea5449d7

Comment 3

2 years ago
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2b96f1b426b
Rank: 15 → 10
Rank: 10 → 7
(Assignee)

Updated

2 years ago
Depends on: 1250934
(Assignee)

Updated

2 years ago
Depends on: 1257616
(Assignee)

Updated

2 years ago
Depends on: 1257620
(Assignee)

Updated

2 years ago
Depends on: 1257621

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/affd6e75efcc

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/affd6e75efcc
Created attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

Review commit: https://reviewboard.mozilla.org/r/43227/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43227/
Attachment #8736339 - Flags: review?(rjesup)
Comment on attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43227/diff/1-2/
Attachment #8736339 - Attachment description: MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup → MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup
Created attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

Review commit: https://reviewboard.mozilla.org/r/43229/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43229/
Attachment #8736343 - Flags: review?(rjesup)
Comment on attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43227/diff/2-3/
Comment on attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43229/diff/1-2/
https://treeherder.mozilla.org/#/jobs?repo=try&revision=408fd5a3b5d3
https://treeherder.mozilla.org/#/jobs?repo=try&revision=574b0ed113ca
https://treeherder.mozilla.org/#/jobs?repo=try&revision=782226adfb53
https://treeherder.mozilla.org/#/jobs?repo=try&revision=181c4fa5a3a6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfaab41200df
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5faaf27c27a1
(Assignee)

Updated

2 years ago
Depends on: 1263738

Comment 17

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3016dc350c6d
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f2f44eaea09
I backed out the Windows side for crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=26153254&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/4236b0313ce3

OSX's patch is still in.
Flags: needinfo?(rjesup)
(Assignee)

Comment 19

2 years ago
padenot: please take a look at https://treeherder.mozilla.org/logviewer.html#?job_id=26153254&repo=mozilla-inbound
Flags: needinfo?(rjesup) → needinfo?(padenot)

Comment 20

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f2f44eaea09
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93ac8f10a2da

Comment 22

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a81573e42b84

Comment 23

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3131a9f5a82f
Clearing NI, the windows issue has been dealt with. Only OpenSL left now !
Flags: needinfo?(padenot)

Comment 25

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a81573e42b84
https://hg.mozilla.org/mozilla-central/rev/3131a9f5a82f
I think it makes sense to scope this bug to enabling full duplex on Desktop.  I'll file a new bug to enable full duplex on Android.
Summary: Enable full-duplex cubeb backends → Enable full-duplex cubeb backends for Desktop
All full-duplex cubeb backends for Desktop have pref'd on.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: leave-open
Resolution: --- → FIXED
See Also: → bug 1267915
Target Milestone: --- → mozilla48
(Assignee)

Updated

2 years ago
Attachment #8736339 - Flags: review?(rjesup) → review+
(Assignee)

Comment 28

2 years ago
Comment on attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

https://reviewboard.mozilla.org/r/43227/#review46207
(Assignee)

Updated

2 years ago
Attachment #8736343 - Flags: review?(rjesup)
(Assignee)

Comment 29

2 years ago
Comment on attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

https://reviewboard.mozilla.org/r/43229/#review46209
(Assignee)

Comment 30

2 years ago
Comment on attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

https://reviewboard.mozilla.org/r/43229/#review46211
Attachment #8736343 - Flags: review+

Updated

2 years ago
Depends on: 1268403
Target Milestone: mozilla48 → mozilla49
(Assignee)

Updated

a year ago
Duplicate of this bug: 1286745
Depends on: 1299324
Depends on: 1307089
You need to log in before you can comment on or make changes to this bug.