1243857 - Enable full-duplex cubeb backends for Desktop

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

Bug for enabling all of the full-duplex backends; leave open until they're all preffed on.

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38335c435a45

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Backed out for bc and devtools failures as seen in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=22f3ea5449d7

Comment 3

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2b96f1b426b

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/affd6e75efcc

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/affd6e75efcc

Comment 6

[Paul Adenot (:padenot)]

Attachment: MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

Review commit: https://reviewboard.mozilla.org/r/43227/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43227/

Comment 7

[Paul Adenot (:padenot)]

Comment on attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43227/diff/1-2/

Comment 8

[Paul Adenot (:padenot)]

Attachment: MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

Review commit: https://reviewboard.mozilla.org/r/43229/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43229/

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43227/diff/2-3/

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/43229/diff/1-2/

Comment 11

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=408fd5a3b5d3

Comment 12

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=574b0ed113ca

Comment 13

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=782226adfb53

Comment 14

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=181c4fa5a3a6

Comment 15

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfaab41200df

Comment 16

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5faaf27c27a1

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3016dc350c6d
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f2f44eaea09

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I backed out the Windows side for crashes like https://treeherder.mozilla.org/logviewer.html#?job_id=26153254&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/4236b0313ce3

OSX's patch is still in.

Comment 19

[Randell Jesup [:jesup] (needinfo me)]

padenot: please take a look at https://treeherder.mozilla.org/logviewer.html#?job_id=26153254&repo=mozilla-inbound

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f2f44eaea09

Comment 21

[Paul Adenot (:padenot)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93ac8f10a2da

Comment 22

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a81573e42b84

Comment 23

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3131a9f5a82f

Comment 24

[Paul Adenot (:padenot)]

Clearing NI, the windows issue has been dealt with. Only OpenSL left now !

Comment 25

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a81573e42b84
https://hg.mozilla.org/mozilla-central/rev/3131a9f5a82f

Comment 26

[Maire Reavy [:mreavy]]

I think it makes sense to scope this bug to enabling full duplex on Desktop.  I'll file a new bug to enable full duplex on Android.

Comment 27

[Maire Reavy [:mreavy]]

All full-duplex cubeb backends for Desktop have pref'd on.

Comment 28

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8736339 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for Windows/WASAPI. r?jesup

https://reviewboard.mozilla.org/r/43227/#review46207

Comment 29

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

https://reviewboard.mozilla.org/r/43229/#review46209

Comment 30

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8736343 [details]
MozReview Request: Bug 1243857 - Enable duplex audio for OSX. r?jesup

https://reviewboard.mozilla.org/r/43229/#review46211