Closed
Bug 1244174
Opened 7 years ago
Closed 7 years ago
Sync tabs UI
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect)
Tracking
(blocking-b2g:2.6+)
People
(Reporter: ferjm, Assigned: danhuang)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(4 files)
|
46 bytes,
text/x-github-pull-request
|
yifan
:
review+
|
Details | Review |
|
110.33 KB,
image/png
|
pekochen
:
ui-review+
|
Details |
|
184.90 KB,
image/png
|
pekochen
:
ui-review+
|
Details |
|
88.30 KB,
image/png
|
pekochen
:
ui-review+
|
Details |
sync-tab-list-focus-on-first-device.png
No description provided.
|
Reporter | |
Updated•7 years ago
|
|
|
Reporter | |
Updated•7 years ago
|
blocking-b2g: --- → 2.6?
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
Whiteboard: [ft:conndevices]
|
||
Updated•7 years ago
|
blocking-b2g: 2.6? → 2.6+
|
||
Comment 1•7 years ago
|
||
tab sync spec updated, v1.1, p13&14 https://drive.google.com/folderview?id=0B4dMhI4hp32OanhJQ1NnMVMydTA&usp=sharing Peko, there is a new UI at page14(screen 3-13). Could you help to update the visual spec? Thank you!
Flags: needinfo?(pchen)
|
||
Comment 2•7 years ago
|
||
Hi please check here for new tab sync spec https://drive.google.com/open?id=0B4K8q1qWmtAvNDNHN2tkY2NJeTQ preview :https://drive.google.com/open?id=0B4K8q1qWmtAvQWxBZnNfaUdCbVE image : https://drive.google.com/open?id=0B4K8q1qWmtAvZmVSRXplTW4ydW8 Thanks!
Flags: needinfo?(pchen)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Hi Peko, Could help update the tab sync part in https://drive.google.com/drive/folders/0B4K8q1qWmtAvWWduYzFycmJuLWs According the tab sync spec v1.1, the device icon would not show in the sync tab list. Thanks!
Flags: needinfo?(pchen)
|
|
||
Comment 4•7 years ago
|
||
UX Spec updated. Added bar of "top sites" at screen 3-7, page13, v1.2. https://drive.google.com/open?id=0B4dMhI4hp32Oa3pta2lab3U1MkE
|
|
||
Comment 5•7 years ago
|
||
Visual spec updated. Please see p.16 https://drive.google.com/open?id=0B4K8q1qWmtAvNzVIWWdGWDF1eUE Thanks
Flags: needinfo?(pchen)
|
||
Comment 6•7 years ago
|
||
|
|
Assignee | |
Comment 7•7 years ago
|
||
Comment on attachment 8734219 [details] [review] [gaia] danhuang1202:1244174_sync_tab_ui > mozilla-b2g:master Hi Yi-Fan, Please help review! This patch update browser top-site view and add sync tab list view. Thanks.
Attachment #8734219 -
Flags: review?(yliao)
|
|
Assignee | |
Comment 8•7 years ago
|
||
Hi Peko, Please help review this picture. This picture shows the sync tab list with focus on the first device item. Thanks.
Attachment #8734265 -
Flags: ui-review?(pchen)
|
|
Assignee | |
Comment 9•7 years ago
|
||
Hi Peko, Please help review this picture. This picture show the sync tab list with expand the first device item. Thanks.
Attachment #8734268 -
Flags: ui-review?(pchen)
|
|
Assignee | |
Comment 10•7 years ago
|
||
Hi Peko, Please help review this picture. This picture display no tabs view in sync tab. Thanks.
Attachment #8734270 -
Flags: ui-review?(pchen)
|
|
||
Updated•7 years ago
|
Attachment #8734270 -
Flags: ui-review?(pchen) → ui-review+
|
|
||
Updated•7 years ago
|
Attachment #8734268 -
Flags: ui-review?(pchen) → ui-review+
|
|
||
Updated•7 years ago
|
Attachment #8734265 -
Flags: ui-review?(pchen) → ui-review+
|
||
Comment 11•7 years ago
|
||
Comment on attachment 8734219 [details] [review] [gaia] danhuang1202:1244174_sync_tab_ui > mozilla-b2g:master Some nits on Github. Thanks!
Attachment #8734219 -
Flags: review?(yliao) → review+
|
|
Assignee | |
Comment 12•7 years ago
|
||
Thanks for the review and all nits are fixed. Merge in master: https://github.com/mozilla-b2g/gaia/commit/a89ff1205ae9ab09d8ab08f3b84ae84a1b19ab56
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•