Status

Firefox OS
Gaia::TV::Browser
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ferjm, Assigned: danhuang)

Tracking

(Blocks: 2 bugs)

unspecified
2.6 S7 - 2/12
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.6+)

Details

(Whiteboard: [ft:conndevices])

Attachments

(4 attachments)

Comment hidden (empty)
(Reporter)

Updated

2 years ago
Blocks: 824026, 1244168
Depends on: 1244170
Target Milestone: --- → 2.6 S7 - 2/12
(Reporter)

Updated

2 years ago
blocking-b2g: --- → 2.6?
(Assignee)

Updated

2 years ago
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Whiteboard: [ft:conndevices]
Depends on: 1256227

Updated

2 years ago
blocking-b2g: 2.6? → 2.6+

Comment 1

2 years ago
tab sync spec updated, v1.1, p13&14
https://drive.google.com/folderview?id=0B4dMhI4hp32OanhJQ1NnMVMydTA&usp=sharing

Peko, there is a new UI at page14(screen 3-13). Could you help to update the visual spec? Thank you!
Flags: needinfo?(pchen)
(Assignee)

Comment 3

2 years ago
Hi Peko,

Could help update the tab sync part in 
https://drive.google.com/drive/folders/0B4K8q1qWmtAvWWduYzFycmJuLWs

According the tab sync spec v1.1, the device icon would not show in the sync tab list.
Thanks!
Flags: needinfo?(pchen)

Comment 4

2 years ago
UX Spec updated. Added bar of "top sites" at screen 3-7, page13, v1.2.
https://drive.google.com/open?id=0B4dMhI4hp32Oa3pta2lab3U1MkE
Visual spec updated.
Please see p.16
https://drive.google.com/open?id=0B4K8q1qWmtAvNzVIWWdGWDF1eUE
Thanks
Flags: needinfo?(pchen)
Created attachment 8734219 [details] [review]
[gaia] danhuang1202:1244174_sync_tab_ui > mozilla-b2g:master
(Assignee)

Comment 7

2 years ago
Comment on attachment 8734219 [details] [review]
[gaia] danhuang1202:1244174_sync_tab_ui > mozilla-b2g:master

Hi Yi-Fan,
Please help review! This patch update browser top-site view and add sync tab list view. Thanks.
Attachment #8734219 - Flags: review?(yliao)
(Assignee)

Comment 8

2 years ago
Created attachment 8734265 [details]
sync-tab-list-focus-on-first-device.png

Hi Peko,
Please help review this picture. This picture shows the sync tab list with focus on the first device item. Thanks.
Attachment #8734265 - Flags: ui-review?(pchen)
(Assignee)

Comment 9

2 years ago
Created attachment 8734268 [details]
sync-tab-list-expand-the-first-device.png

Hi Peko,
Please help review this picture. This picture show the sync tab list with expand the first device item. Thanks.
Attachment #8734268 - Flags: ui-review?(pchen)
(Assignee)

Comment 10

2 years ago
Created attachment 8734270 [details]
no-tabs-view.png

Hi Peko,
Please help review this picture. This picture display no tabs view in sync tab. Thanks.
Attachment #8734270 - Flags: ui-review?(pchen)

Updated

2 years ago
Attachment #8734270 - Flags: ui-review?(pchen) → ui-review+

Updated

2 years ago
Attachment #8734268 - Flags: ui-review?(pchen) → ui-review+

Updated

2 years ago
Attachment #8734265 - Flags: ui-review?(pchen) → ui-review+
Comment on attachment 8734219 [details] [review]
[gaia] danhuang1202:1244174_sync_tab_ui > mozilla-b2g:master

Some nits on Github. Thanks!
Attachment #8734219 - Flags: review?(yliao) → review+
(Assignee)

Comment 12

2 years ago
Thanks for the review and all nits are fixed.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/a89ff1205ae9ab09d8ab08f3b84ae84a1b19ab56
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.