Closed Bug 1245447 Opened 4 years ago Closed 4 years ago
Browser is blocked in customize mode if Pocket button is placed in Menu panel and then restored
58 bytes, text/x-review-board-request
Note: logged as requested in bug 1245074 comment 6 Affected versions: latest Aurora 46.0a2 and Nightly 47.0a1 (from 2016-02-02), e10s enabled/disabled Affected platforms: Ubuntu 14.04 32-bit, Mac OS X 10.9.5 and Windows 7 64-bit Steps to reproduce: 1. Launch Firefox with a clean profile. 2. Click on Menu panel (Hamburger button). 3. Select Customize. 4. Drag Pocket button to the Menu Panel. 5. Click 'Restore Defaults' button. 6. Exit customize mode - click Exit Customize button or Hamburger button or close tab. Expected results: Customize mode is properly closed. Actual results: Unable to exit customize mode. Additional notes: 1. Screen recording: https://goo.gl/6qnSeO 1.1. At step 4, if the button is placed at the top of the Menu panel, an empty spot appears after restoring (visible in the video too). 2. Browser console output: > CustomizeMode:DOMException [NotFoundError: "Node was not found" > code: 8 > nsresult: 0x80530008 > location: resource://app/modules/CustomizableUI.jsm:1184]' thrown by Promise-backend.js:940 3. Not reproducible if any other button from toolbar is moved to the Menu panel. 4. Unaffected version - 45 beta 2 (Build ID: 20160201143558) and 44.0RC build 3 (Build ID: 20160123151951). 5. Regression range: Last good revision: 0c12d4229be0068eb1b9beb5064b800f12143f20 First bad revision: 3ba655f6bc67660a2dcfc4c2a5b3d0d17714f53d Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=0c12d4229be0068eb1b9beb5064b800f12143f20&tochange=3ba655f6bc67660a2dcfc4c2a5b3d0d17714f53d Regressed by 3ba655f6bc67 Shane Caraveo — Bug 1215694 move pocket to a system addon
Tracking for 46+ since this is a recent regression.
Shane, can you please look into this?
Review commit: https://reviewboard.mozilla.org/r/34233/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34233/
Attachment #8717595 - Flags: review?(gijskruitbosch+bugs)
The above patch fixes the breakage in customization/reset, it does not fix default position for the pocket button after reset.
Keeping the proper default position after reset is in bug 1247045
Attachment #8717595 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/integration/fx-team/rev/745c98ace7f0a3420f9b2079ece59064e5a33196 Bug 1245447 fix CUI customization breakage, r=gijs
Comment on attachment 8717595 [details] MozReview Request: Bug 1245447 fix CUI customization breakage, r?gijs Approval Request Comment [Feature/regressing bug #]: 1215694 [User impact if declined]: possible to break CUI customization in a way that requires firefox restart [Describe test coverage new/current, TreeHerder]: manual [Risks and why]: low, this is removal code that tried to fix the "default" position of the pocket button after CUI reset [String/UUID change made/needed]: none
Attachment #8717595 - Flags: approval-mozilla-aurora?
Let's verify the fix before we uplift this. adalucinet can you have a look since you found the bug originally? Thanks!
Just noticed she it out on PTO. Andrei can you find someone else to verify the fix?
Reproduced the issue on Nightly 2016-02-02 Win 7. Verified fixed 47.0a1 (2016-02-15).
Comment on attachment 8717595 [details] MozReview Request: Bug 1245447 fix CUI customization breakage, r?gijs Fix for system addon issue, verified on m-c. Please uplift to aurora.
Attachment #8717595 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Setting the flag for verification on 46.
You need to log in before you can comment on or make changes to this bug.