Closed Bug 1245476 Opened 7 years ago Closed 7 years ago

Disable GTK3 in Firefox 45

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Version:
45 Branch
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 blocking fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file, 1 obsolete file)

gtk3-disable.diff
8.10 KB, patch
karlt
: review+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
As discussed in 1227024, bug 1205199 is critical enough to disable gtk 3 in 45.

Also:
* 45 is an ESR release, it would be safer to introduce gtk 3 in 46
* We only had two beta with gtk3, this is not enough for such important changes
* We need time to make sure gtk2 is still in a good shape
I am also concerned by bug 1239962
Attached patch gtk3-disable.diff (obsolete) — — Splinter Review 
Patch from Bug 1227024 rebased
Attachment #8715711 - Flags: review?(karlt)
Assignee: nobody → sledru
Severity: normal → blocker
Status: NEW → ASSIGNED
OS: Unspecified → Linux
Hardware: Unspecified → All
Target Milestone: --- → mozilla45
Version: unspecified → 45 Branch
Blocks: 1245926
Comment on attachment 8715711 [details] [diff] [review]
gtk3-disable.diff

Thanks.  I suspect http://hg.mozilla.org/releases/mozilla-beta/rev/d7844fe50165 will also need to be reverted, but Mike is the one who knows about this.

Something's been making unnecessary whitespace changes, which can lead to unnecessary merge conflicts.
Attachment #8715711 - Flags: review?(mh+mozilla)
Attachment #8715711 - Flags: review?(karlt)
Attachment #8715711 - Flags: feedback+
Thanks, I will remove the whitespace changes before the push.
Comment on attachment 8715711 [details] [diff] [review]
gtk3-disable.diff

Review of attachment 8715711 [details] [diff] [review]:
-----------------------------------------------------------------

As Karl says, this won't work without an accompanying backout of the mozconfig.gtk change, or just scraping mozconfig.gtk to contain:

  ac_add_options --enable-default-toolkit=cairo-gtk2

as indicated on the comment at the top of the file.
Attachment #8715711 - Flags: review?(mh+mozilla) → review+
here it is
Attachment #8715711 - Attachment is obsolete: true
Attachment #8716228 - Flags: review?(karlt)
Comment on attachment 8716228 [details] [diff] [review]
gtk3-disable.diff

[Triage Comment]
Using my supercow power, let's take it.
Attachment #8716228 - Flags: approval-mozilla-beta+
Attachment #8716228 - Flags: review?(karlt) → review+
Depends on: 1246854
We need to remove the mention to GTK3 in the Firefox 45 release notes: https://www.mozilla.org/en-US/firefox/45.0beta/releasenotes/.
Flags: needinfo?(sledru)
I updated it an hour ago to "
GTK3 integration (GNU/Linux only). Disabled after beta 4
"
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.