Closed
Bug 1245476
Opened 9 years ago
Closed 9 years ago
Disable GTK3 in Firefox 45
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file, 1 obsolete file)
|
8.10 KB,
patch
|
karlt
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
As discussed in 1227024, bug 1205199 is critical enough to disable gtk 3 in 45.
Also:
* 45 is an ESR release, it would be safer to introduce gtk 3 in 46
* We only had two beta with gtk3, this is not enough for such important changes
* We need time to make sure gtk2 is still in a good shape
|
Assignee | |
Updated•9 years ago
|
status-firefox45:
--- → affected
tracking-firefox46:
--- → blocking
|
|
Assignee | |
Comment 1•9 years ago
|
||
I am also concerned by bug 1239962
|
|
Assignee | |
Updated•9 years ago
|
tracking-firefox45:
--- → blocking
tracking-firefox46:
blocking → ---
|
|
Assignee | |
Comment 2•9 years ago
|
||
Patch from Bug 1227024 rebased
Attachment #8715711 -
Flags: review?(karlt)
|
||
Updated•9 years ago
|
Assignee: nobody → sledru
Severity: normal → blocker
Status: NEW → ASSIGNED
OS: Unspecified → Linux
Hardware: Unspecified → All
Target Milestone: --- → mozilla45
Version: unspecified → 45 Branch
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8715711 [details] [diff] [review]
gtk3-disable.diff
Thanks. I suspect http://hg.mozilla.org/releases/mozilla-beta/rev/d7844fe50165 will also need to be reverted, but Mike is the one who knows about this.
Something's been making unnecessary whitespace changes, which can lead to unnecessary merge conflicts.
Attachment #8715711 -
Flags: review?(mh+mozilla)
Attachment #8715711 -
Flags: review?(karlt)
Attachment #8715711 -
Flags: feedback+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Thanks, I will remove the whitespace changes before the push.
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8715711 [details] [diff] [review]
gtk3-disable.diff
Review of attachment 8715711 [details] [diff] [review]:
-----------------------------------------------------------------
As Karl says, this won't work without an accompanying backout of the mozconfig.gtk change, or just scraping mozconfig.gtk to contain:
ac_add_options --enable-default-toolkit=cairo-gtk2
as indicated on the comment at the top of the file.
Attachment #8715711 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
here it is
Attachment #8715711 -
Attachment is obsolete: true
Attachment #8716228 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8716228 [details] [diff] [review]
gtk3-disable.diff
[Triage Comment]
Using my supercow power, let's take it.
Attachment #8716228 -
Flags: approval-mozilla-beta+
|
|
||
Updated•9 years ago
|
Attachment #8716228 -
Flags: review?(karlt) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Comment 9•9 years ago
|
||
We need to remove the mention to GTK3 in the Firefox 45 release notes: https://www.mozilla.org/en-US/firefox/45.0beta/releasenotes/.
Flags: needinfo?(sledru)
|
|
Assignee | |
Comment 10•9 years ago
|
||
I updated it an hour ago to "
GTK3 integration (GNU/Linux only). Disabled after beta 4
"
Flags: needinfo?(sledru)
You need to log in
before you can comment on or make changes to this bug.
Description
•