Closed Bug 1245926 Opened 4 years ago Closed 4 years ago

disable GTK3 in Thunderbird 45

Categories

(Thunderbird :: OS Integration, defect)

45 Branch
Unspecified
Linux
defect
Not set

Tracking

(thunderbird44 wontfix, thunderbird45+ fixed, thunderbird46 wontfix, thunderbird47 wontfix)

RESOLVED FIXED
Thunderbird 45.0
Tracking Status
thunderbird44 --- wontfix
thunderbird45 + fixed
thunderbird46 --- wontfix
thunderbird47 --- wontfix

People

(Reporter: rkent, Assigned: mkmelin)

References

Details

Attachments

(1 file, 2 obsolete files)

With bug 1245476 giving up on gtk3 for FF45, we should probably do the same thing in TB. But let's discuss it rather than just asking me to blindly port the FF changes.
OS: Unspecified → Linux
Blocks: 1245853
I asked about  proceeding with beta 45b1 with updates throttled or without watershed...

bhearsum	wsmwk: ... if it's going to be the last beta prior to enabling gtk3, i strongly recommend shipping it with the new information in the update url
bhearsum	otherwise you'll have to ship a hotfix with that before enabling gtk3
bhearsum	no opinion here when it comes to throttling
It would be great if one of our Linux devs could prepare the needed patches for this, rather than me who is less knowledgeable. Magnus?

AFAIU we have not shipped a beta yet with gtk3 enabled, right? If so, that probably means we should not enable updates for the current 45.0b1 because that is going to create new uncertainties.

bhearsum's remarks start with "if it's going to be the last beta prior to enabling gtk3" which is false, which means I don't see how the rest of his remarks are relevant.

It would also be great to get confirmation from Thunderbird devs that disabling gtk3 for beta45 is in fact the correct thing to do.
Flags: needinfo?(mkmelin+mozilla)
(In reply to Kent James (:rkent) from comment #2)
> AFAIU we have not shipped a beta yet with gtk3 enabled, right? If so, that
> probably means we should not enable updates for the current 45.0b1 because
> that is going to create new uncertainties.

b1 with gtk3 enabled is available for download. https://archive.mozilla.org/pub/thunderbird/releases/45.0b1/
But we have not enabled updates. 

 
> bhearsum's remarks start with "if it's going to be the last beta prior to
> enabling gtk3" which is false, which means I don't see how the rest of his
> remarks are relevant.

I believe he means "the last beta prior to enabling gtk3 for updates"


> It would also be great to get confirmation from Thunderbird devs that
> disabling gtk3 for beta45 is in fact the correct thing to do.

There's is actually NO question we want to disable gtk3 for what we ultimately ship as 45 beta. The question is what to do about b1, since we decided for a variety of reasons to finish it off with gtk3 enabled. 

I believe we want to do a b2 with gtk3 disabled, and not enable b1 for updates. The question then is, is a balrog watershed needed for b2?
Well the balrog watershed is necessary because offering a GTK3 update to a user with <GTK3.4 will break TB

From Firefox prereq:
Firefox will not run at all without the following libraries or packages:

    GTK+ 3.4 or higher

I just wonder what advantages , if any GTK3 offers
(In reply to Joe Sabash [:JoeS1] from comment #4)
> Well the balrog watershed is necessary because offering a GTK3 update to a
> user with <GTK3.4 will break TB
> 
> From Firefox prereq:
> Firefox will not run at all without the following libraries or packages:
> 
>     GTK+ 3.4 or higher

I really wonder how many users:
- install a mozilla-provided binary instead of their distro's package
- among those, have a weird (still maintained) distro shipping such an outdated gtk3

Gtk 3.4 was released in march 2012...

Wasnt there metrics collected on gtk3 version through telemetry ?

> I just wonder what advantages , if any GTK3 offers

It's just more modern/integrated in today's desktop environments. Fwiw, i've been using tb beta w/gtk3 for the past 6 months or so without serious issues.
Yes sounds like we want to disable it.
Flags: needinfo?(mkmelin+mozilla)
Attached patch bug1245926_disable_tb_gtk3.patch (obsolete) — Splinter Review
Untested, but this should be it.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #8717573 - Flags: review?(aleth)
Comment on attachment 8717573 [details] [diff] [review]
bug1245926_disable_tb_gtk3.patch

Review of attachment 8717573 [details] [diff] [review]:
-----------------------------------------------------------------

What about linux64/releng.manifest?
Attached patch bug1245926_disable_tb_gtk3.patch (obsolete) — Splinter Review
Whops
Attachment #8717573 - Attachment is obsolete: true
Attachment #8717573 - Flags: review?(aleth)
Attachment #8717582 - Flags: review?(aleth)
Comment on attachment 8717582 [details] [diff] [review]
bug1245926_disable_tb_gtk3.patch

Review of attachment 8717582 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8717582 - Flags: review?(aleth) → review+
Does not apply on c-b.
Flags: needinfo?(mkmelin+mozilla)
Had an outdated c-b tree...
Attachment #8717582 - Attachment is obsolete: true
Flags: needinfo?(mkmelin+mozilla)
Attachment #8717609 - Flags: review+
https://hg.mozilla.org/releases/comm-beta/rev/d80d60260baa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
Attachment #8717609 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.