Closed
Bug 1245730
Opened 9 years ago
Closed 9 years ago
Remove "data-project" dead code from trychooser
Categories
(Infrastructure & Operations Graveyard :: CIDuty, task)
Infrastructure & Operations Graveyard
CIDuty
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: aselagea)
Details
(Keywords: trychooser)
Attachments
(2 files)
|
8.05 KB,
patch
|
kmoir
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
|
706 bytes,
patch
|
kmoir
:
review+
aselagea
:
checked-in+
|
Details | Diff | Splinter Review |
Bug 855591 added it, with no discussion in the bug other than "The disable_filters stuff is probably overkill." By the time of bug 1039771 which circumvented it, sfink couldn't remember why he had added it, though the guesses there about Android and B2G tests being so wildly named that there was no consistent thing to filter on for them are reasonable. Now it's just dead code which if it accidentally came back to life would do something that we very much do not want to have done.
|
||
Updated•9 years ago
|
Component: Tools → Buildduty
QA Contact: hwine → bugspam.Callek
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → alin.selagea
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8715815 -
Flags: review?(kmoir)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8715815 [details] [diff] [review]
bug_1245730.patch
There are references to data-project in trychooser.js that need to be removed as well.
Attachment #8715815 -
Flags: review?(kmoir) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
I'm not really familiar with javascript, but I guess these are the changes needed in this case. Please correct me if I'm wrong :-)
Attachment #8715895 -
Flags: review?(kmoir)
|
|
||
Updated•9 years ago
|
Attachment #8715895 -
Flags: review?(kmoir) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8715815 -
Flags: checked-in+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8715895 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8715895 -
Flags: review+ → checked-in+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Updated TryChooser to reflect the changes.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Release Engineering → Infrastructure & Operations
|
|
||
Updated•5 years ago
|
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•