Closed
Bug 1248246
Opened 9 years ago
Closed 9 years ago
Port Bug 1246874 - Unify GRE_BUILDID and MOZ_APP_BUILDID at the build system level for c-c
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 47.0
People
(Reporter: aleth, Assigned: aleth)
References
Details
Attachments
(2 files)
1.89 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
4.74 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
GRE_BUILDID is no more.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8719273 -
Flags: review?(clokep)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
I have the sneaking suspicion some of those printconfigsetting.py calls and defines are obsolete as well, but this is the minimal port.
Attachment #8719274 -
Flags: review?(philipp)
Assignee | ||
Updated•9 years ago
|
Attachment #8719273 -
Attachment is obsolete: true
Attachment #8719273 -
Flags: review?(clokep)
Assignee | ||
Updated•9 years ago
|
Attachment #8719273 -
Attachment is obsolete: false
Attachment #8719273 -
Flags: review?(clokep)
Comment 3•9 years ago
|
||
Comment on attachment 8719273 [details] [diff] [review]
Replace GRE_BUILDID with MOZ_BUILDID, im part
Review of attachment 8719273 [details] [diff] [review]:
-----------------------------------------------------------------
Seems fairly sane.
Attachment #8719273 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/744ee111af426789a6d6fff8c71b779eb5db5c58
Bug 1248246 - Replace GRE_BUILDID with MOZ_BUILDID, im part. r=clokep
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Pre-merge ping to avoid the need for uplifts ;)
Flags: needinfo?(philipp)
Updated•9 years ago
|
Attachment #8719274 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/05f5b779c4faf468de7b40abd160d9f8168fa513
Bug 1248246 - Replace GRE_BUILDID with MOZ_BUILDID, mail and calendar part. r=Fallen
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(philipp)
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
You need to log in
before you can comment on or make changes to this bug.
Description
•