Closed Bug 1247138 Opened 4 years ago Closed 4 years ago

Handle MSE audio configuration change

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- affected
firefox48 --- affected
firefox49 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: meta)

Attachments

(2 files)

Change during playback of the audio format isn't supported (either change in the number of channels, change in the sampling rate etc).

We should support it.
Duplicate of this bug: 1244185
Hi, I noticed this was "unassigned"; is there anyway to actually get someone to work on it? Thanks :)
no need. it will be worked on and assigned to the relevant person when this task will be started (hopefully soon)
Priority: -- → P2
Depends on: 1248861
Duplicate of this bug: 1248696
Depends on: 1262746
Keywords: meta
Blocks: 1232252
Depends on: 1262753
For now, the plan will be to always downmix the audio to stereo (or upmix to audio if the stream is mono)

If the audio sampling rate changes, then it will be resampled to the first sampling rate seen (or maybe use a constant one like either 44.1 or 48kHz, so that if the first sampling rate seen is 8kHz we don't end up sounding awful even with higher quality audio)
Summary: Handle audio configuration change → Handle MSE audio configuration change
Depends on: 1264200
Assignee: nobody → jyavenard
Comment on attachment 8741307 [details]
MozReview Request: Bug 1247138: [MSE] P1. Allow change of audio format. r?gerald

https://reviewboard.mozilla.org/r/46369/#review42943
Attachment #8741307 - Flags: review?(gsquelart) → review+
Comment on attachment 8741307 [details]
MozReview Request: Bug 1247138: [MSE] P1. Allow change of audio format. r?gerald

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46369/diff/1-2/
Comment on attachment 8741569 [details]
MozReview Request: Bug 1247138: [MSE] P2. Add mochitest. r?gerald

https://reviewboard.mozilla.org/r/46575/#review43223
Attachment #8741569 - Flags: review?(gsquelart) → review+
Comment on attachment 8741307 [details]
MozReview Request: Bug 1247138: [MSE] P1. Allow change of audio format. r?gerald

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46369/diff/2-3/
Comment on attachment 8741569 [details]
MozReview Request: Bug 1247138: [MSE] P2. Add mochitest. r?gerald

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46575/diff/1-2/
https://hg.mozilla.org/mozilla-central/rev/fbcd1815776a
https://hg.mozilla.org/mozilla-central/rev/34f5a7144be3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Backed out in https://hg.mozilla.org/mozilla-central/rev/a4790cb5d540 for apparently making media mochitests on OSX 10.6 permafail like https://treeherder.mozilla.org/logviewer.html#?job_id=26185066&repo=mozilla-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(jyavenard)
Resolution: FIXED → ---
backed out for backout in bug 1264199
Flags: needinfo?(jyavenard)
https://hg.mozilla.org/mozilla-central/rev/39842e4e5553
https://hg.mozilla.org/mozilla-central/rev/0c4758a01aab
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.