1185827 - Handle audio configuration change

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Jean-Yves Avenard [:jya]]

At this stage, this is likely the most important feature required to have an almost complete MSE support.

We do not handle changing audio configuration (either change of sampling rate or channels count).

Worse, it could result in a crash (assert) or out of bound memory access.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] Error when detecting an audio format configuration change.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] Error when detecting an audio format configuration change.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8647838 [details] [diff] [review]
[MSE] Error when detecting an audio format configuration change.

Review of attachment 8647838 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/TrackBuffersManager.cpp
@@ +978,5 @@
>      // 6. Set first initialization segment received flag to true.
>      mFirstInitializationSegmentReceived = true;
>    } else {
> +    // Check that audio configuration hasn't changed as this is something
> +    // we do not support yet (bug bug 1185827).

Remove redundant 'bug'.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3e2e816df2e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d3e2e816df2e

Comment 6

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7d421d645713

Comment 7

[Ralph Giles (:rillian)]

Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c

Comment 8

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f3d195cea5f4