Closed Bug 1185827 Opened 5 years ago Closed 5 years ago

Handle audio configuration change

Categories

(Core :: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

At this stage, this is likely the most important feature required to have an almost complete MSE support.

We do not handle changing audio configuration (either change of sampling rate or channels count).

Worse, it could result in a crash (assert) or out of bound memory access.
See Also: → 1185828
Attachment #8647837 - Flags: review?(gsquelart) → review-
Comment on attachment 8647838 [details] [diff] [review]
[MSE] Error when detecting an audio format configuration change.

Review of attachment 8647838 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/mediasource/TrackBuffersManager.cpp
@@ +978,5 @@
>      // 6. Set first initialization segment received flag to true.
>      mFirstInitializationSegmentReceived = true;
>    } else {
> +    // Check that audio configuration hasn't changed as this is something
> +    // we do not support yet (bug bug 1185827).

Remove redundant 'bug'.
Attachment #8647838 - Flags: review?(gsquelart) → review+
https://hg.mozilla.org/mozilla-central/rev/d3e2e816df2e
Assignee: nobody → jyavenard
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1197083
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 1185828
Depends on: 1247138
You need to log in before you can comment on or make changes to this bug.