Last Comment Bug 1247229 - (basic-shape-ship) Ship basic shapes clip-path clipping
(basic-shape-ship)
: Ship basic shapes clip-path clipping
Status: ASSIGNED
[behind pref layout.css.clip-path-sha...
: dev-doc-needed, DevAdvocacy, leave-open
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: All All
: P3 normal with 1 vote (vote)
: ---
Assigned To: C.J. Ku[:cjku](UTC+8)
:
: Jet Villegas (:jet)
Mentors:
https://drafts.fxtf.org/css-masking-1...
Depends on: 1266316 1058162 1075457 1110460 1246762 1266570 1266868 1269990 1269992 1278264 1289011 1290650 1290864 1293590 1297333 1303654 1313276 1313898 1324713
Blocks: css3test css-masking-1 basic-shape
  Show dependency treegraph
 
Reported: 2016-02-10 03:52 PST by Jonathan Watt [:jwatt]
Modified: 2016-12-20 01:07 PST (History)
25 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
?

MozReview Requests
Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:
Show discarded requests

Attachments
patch to flip the pref (1.06 KB, patch)
2016-04-20 17:56 PDT, Jonathan Watt [:jwatt]
dholbert: review+
Details | Diff | Splinter Review
Bug 1247229 - Turn on layout.css.clip-path-shapes.enabled (58 bytes, text/x-review-board-request)
2016-12-15 19:54 PST, C.J. Ku[:cjku](UTC+8)
no flags Details | Review

Description User image Jonathan Watt [:jwatt] 2016-02-10 03:52:34 PST
+++ This bug was initially created as a clone of Bug #1075457 +++

Bug 1075457 implemented basic shapes clip-path clipping for HTML elements but no decision was made about flipping the pref to let this feature ride the trains. Ideally I'd like to fix bug 1246741 (support in SVG) and bug 1246762 (support for inset()) first. There's also bug 1110460 (support animations/transitions). I think we could ship as-is, but am interested in anyone else's thoughts on whether we should fix those bugs first.
Comment 1 User image Sebastian Zartner [:sebo] 2016-02-11 05:49:37 PST
I'd say:
- bug 1246741: in a followup
- bug 1246762: either before shipping or in a followup and remove it from parsing for now (it's currently recognized as valid)
- bug 1110460: in a followup

Sebastian
Comment 2 User image Jonathan Watt [:jwatt] 2016-04-20 17:56:05 PDT
Created attachment 8743625 [details] [diff] [review]
patch to flip the pref
Comment 3 User image Daniel Holbert [:dholbert] 2016-04-20 18:00:07 PDT
Comment on attachment 8743625 [details] [diff] [review]
patch to flip the pref

Review of attachment 8743625 [details] [diff] [review]:
-----------------------------------------------------------------

We might want to put this behind an #ifndef RELEASE_BUILD until it's gotten more testing (and we can always remove that guard before it hits beta if everything looks good, i.e. make a call at that point to allow it to continue riding the trains)

Up to you; r=me regardless
Comment 5 User image Jonathan Watt [:jwatt] 2016-04-20 18:05:53 PDT
Okay, I did that.
Comment 6 User image Jonathan Watt [:jwatt] 2016-04-20 18:10:19 PDT
Sent intent to ship:

https://groups.google.com/forum/#!topic/mozilla.dev.platform/1cTAxTf916c
Comment 8 User image Jonathan Watt [:jwatt] 2016-04-21 00:31:54 PDT
Note https://lists.w3.org/Archives/Public/public-fx/2016AprJun/0000.html
Comment 9 User image Robert Longson 2016-05-02 03:55:49 PDT
Seems a shame not to complete this for SVG first. Especially as I think it will leave SVG in a strange position, the clip-path will not affect rendering but will affect elementFromPoint for SVG I think.
Comment 10 User image Astley Chen [:astley] UTC+8 2016-11-10 01:50:29 PST
Comment on attachment 8743625 [details] [diff] [review]
patch to flip the pref

We plan to pref-on clip-path support on nightly & aurora from Firefox 53(bug 1303654) and clean up all dependencies of this bug before riding the train.
Comment 11 User image Astley Chen [:astley] UTC+8 2016-12-09 16:41:07 PST
Note that basic shapes support for clip-path already enabled in Firefox53(bug 1303654). Now CJ will be working on cleaning all subsequent bugs to ensure we are able to ship this feature soon.
Comment 12 User image C.J. Ku[:cjku](UTC+8) 2016-12-15 19:54:48 PST Comment hidden (mozreview-request)

Note You need to log in before you can comment on or make changes to this bug.