|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
+++ This bug was initially created as a clone of Bug #1075457 +++ Bug 1075457 implemented basic shapes clip-path clipping for HTML elements but no decision was made about flipping the pref to let this feature ride the trains. Ideally I'd like to fix bug 1246741 (support in SVG) and bug 1246762 (support for inset()) first. There's also bug 1110460 (support animations/transitions). I think we could ship as-is, but am interested in anyone else's thoughts on whether we should fix those bugs first.
I'd say: - bug 1246741: in a followup - bug 1246762: either before shipping or in a followup and remove it from parsing for now (it's currently recognized as valid) - bug 1110460: in a followup Sebastian
Created attachment 8743625 [details] [diff] [review] patch to flip the pref
Comment on attachment 8743625 [details] [diff] [review] patch to flip the pref Review of attachment 8743625 [details] [diff] [review]: ----------------------------------------------------------------- We might want to put this behind an #ifndef RELEASE_BUILD until it's gotten more testing (and we can always remove that guard before it hits beta if everything looks good, i.e. make a call at that point to allow it to continue riding the trains) Up to you; r=me regardless
Okay, I did that.
Sent intent to ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/1cTAxTf916c
Seems a shame not to complete this for SVG first. Especially as I think it will leave SVG in a strange position, the clip-path will not affect rendering but will affect elementFromPoint for SVG I think.
Comment on attachment 8743625 [details] [diff] [review] patch to flip the pref We plan to pref-on clip-path support on nightly & aurora from Firefox 53(bug 1303654) and clean up all dependencies of this bug before riding the train.
Note that basic shapes support for clip-path already enabled in Firefox53(bug 1303654). Now CJ will be working on cleaning all subsequent bugs to ensure we are able to ship this feature soon.
Comment on attachment 8819169 [details] Bug 1247229 - Turn on layout.css.clip-path-shapes.enabled on all releases. https://reviewboard.mozilla.org/r/99018/#review112196 r=me
Thanks. OK. (In reply to Daniel Holbert [:dholbert] from comment #14) > Comment on attachment 8819169 [details] > Bug 1247229 - Turn on layout.css.clip-path-shapes.enabled on all releases. > > https://reviewboard.mozilla.org/r/99018/#review112196 > > r=me Thanks. OK, let's go
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/533ce5768b78 Turn on layout.css.clip-path-shapes.enabled on all releases. r=dholbert
Can we close this out? (This was marked "leave-open" back in comment 5, which is why it wasn't auto-closed in comment 17.)
Just to be sure to have understood correctly: this was turned on long ago (47) for Nightly and Aurora, this has been now turned on in Firefox 54 for Beta and Release [still only for HTML, not SVG elements], meaning that it will ride the train once reaching Beta and Release (but not now yet). Can you confirm or correct me?
pretty sure SVG works too.
Clear leave-open and close this bug per comment 18. (In reply to Jean-Yves Perrier [:teoli] from comment #19) > Can you confirm or correct me? clip-path prop support had been enabled long time ago. What we really enabled here is <basic-shape> value support, note that this feature was prefed on on nightly & aurora since Firefox 53(bug 1303654) and shipped since Firefox 54(this bug).
I've updated the documentation and release notes: https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path https://developer.mozilla.org/en-US/Firefox/Experimental_features https://developer.mozilla.org/en-US/Firefox/Releases/54 Sebastian