Bug 1247229 (basic-shape-ship)

Ship basic shapes clip-path clipping

RESOLVED FIXED in mozilla54

Status

()

Core
Layout
P3
normal
RESOLVED FIXED
a year ago
18 days ago

People

(Reporter: jwatt, Assigned: cjku)

Tracking

(Blocks: 4 bugs, {dev-doc-complete, DevAdvocacy})

unspecified
mozilla54
dev-doc-complete, DevAdvocacy
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [DevRel:P1], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
+++ This bug was initially created as a clone of Bug #1075457 +++

Bug 1075457 implemented basic shapes clip-path clipping for HTML elements but no decision was made about flipping the pref to let this feature ride the trains. Ideally I'd like to fix bug 1246741 (support in SVG) and bug 1246762 (support for inset()) first. There's also bug 1110460 (support animations/transitions). I think we could ship as-is, but am interested in anyone else's thoughts on whether we should fix those bugs first.
(Reporter)

Updated

a year ago
relnote-firefox: --- → ?
(Reporter)

Updated

a year ago
I'd say:
- bug 1246741: in a followup
- bug 1246762: either before shipping or in a followup and remove it from parsing for now (it's currently recognized as valid)
- bug 1110460: in a followup

Sebastian
(Reporter)

Comment 2

a year ago
Created attachment 8743625 [details] [diff] [review]
patch to flip the pref
Attachment #8743625 - Flags: review?(dholbert)
Comment on attachment 8743625 [details] [diff] [review]
patch to flip the pref

Review of attachment 8743625 [details] [diff] [review]:
-----------------------------------------------------------------

We might want to put this behind an #ifndef RELEASE_BUILD until it's gotten more testing (and we can always remove that guard before it hits beta if everything looks good, i.e. make a call at that point to allow it to continue riding the trains)

Up to you; r=me regardless
Attachment #8743625 - Flags: review?(dholbert) → review+

Comment 4

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/78c0ed233443
(Reporter)

Comment 5

a year ago
Okay, I did that.
Keywords: leave-open
Whiteboard: [currently behind pref layout.css.clip-path-shapes.enabled] → [controlled by the pref layout.css.clip-path-shapes.enabled]
(Reporter)

Comment 6

a year ago
Sent intent to ship:

https://groups.google.com/forum/#!topic/mozilla.dev.platform/1cTAxTf916c

Comment 7

a year ago
backout
https://hg.mozilla.org/integration/mozilla-inbound/rev/41dfd4ad33b7
Blocks: 913153
(Reporter)

Updated

a year ago
See Also: → bug 1246764
(Reporter)

Comment 8

a year ago
Note https://lists.w3.org/Archives/Public/public-fx/2016AprJun/0000.html
(Reporter)

Updated

a year ago
Depends on: 1266316
Blocks: 1266868
No longer blocks: 1266868
Depends on: 1266868

Comment 9

a year ago
Seems a shame not to complete this for SVG first. Especially as I think it will leave SVG in a strange position, the clip-path will not affect rendering but will affect elementFromPoint for SVG I think.
Depends on: 1269992
Depends on: 1269990

Updated

11 months ago
Depends on: 1278264
Depends on: 1058162
Depends on: 1289011
Depends on: 1290864
Depends on: 1290650
(Assignee)

Updated

9 months ago
Depends on: 1293590
Keywords: DevAdvocacy
Whiteboard: [controlled by the pref layout.css.clip-path-shapes.enabled] → [controlled by the pref layout.css.clip-path-shapes.enabled][DevRel:P1]
Depends on: 1297333
(Assignee)

Updated

8 months ago
Depends on: 1299876
Depends on: 1266570
Depends on: 1303654
Priority: -- → P3
Depends on: 1313898
Comment on attachment 8743625 [details] [diff] [review]
patch to flip the pref

We plan to pref-on clip-path support on nightly & aurora from Firefox 53(bug 1303654) and clean up all dependencies of this bug before riding the train.
Attachment #8743625 - Attachment is obsolete: true
(Assignee)

Updated

6 months ago
No longer depends on: 1246741
Depends on: 1319407
Assignee: jwatt → cku
Blocks: 1312613
Note that basic shapes support for clip-path already enabled in Firefox53(bug 1303654). Now CJ will be working on cleaning all subsequent bugs to ensure we are able to ship this feature soon.
Status: NEW → ASSIGNED
Whiteboard: [controlled by the pref layout.css.clip-path-shapes.enabled][DevRel:P1] → [behind pref layout.css.clip-path-shapes.enabled on Beta&Release][DevRel:P1]
See Also: bug 1246764
(Assignee)

Updated

5 months ago
Depends on: 1313276
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Alias: basic-shape
(Assignee)

Updated

4 months ago
Alias: basic-shape → basic-shape-ship
(Assignee)

Updated

4 months ago
Blocks: 1324179
(Assignee)

Updated

4 months ago
No longer depends on: 1299876
Depends on: 1324713
(Assignee)

Updated

4 months ago
No longer depends on: 1319407
(Assignee)

Updated

3 months ago
No longer depends on: 1266316
Blocks: 1242029
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8819169 - Flags: review?(dholbert)

Comment 14

3 months ago
mozreview-review
Comment on attachment 8819169 [details]
Bug 1247229 - Turn on layout.css.clip-path-shapes.enabled on all releases.

https://reviewboard.mozilla.org/r/99018/#review112196

r=me
Attachment #8819169 - Flags: review?(dholbert) → review+
(Assignee)

Comment 15

3 months ago
Thanks. OK. (In reply to Daniel Holbert [:dholbert] from comment #14)
> Comment on attachment 8819169 [details]
> Bug 1247229 - Turn on layout.css.clip-path-shapes.enabled on all releases.
> 
> https://reviewboard.mozilla.org/r/99018/#review112196
> 
> r=me

Thanks. OK, let's go

Comment 16

3 months ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/533ce5768b78
Turn on layout.css.clip-path-shapes.enabled on all releases. r=dholbert

Comment 17

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/533ce5768b78
Can we close this out? (This was marked "leave-open" back in comment 5, which is why it wasn't auto-closed in comment 17.)
Flags: needinfo?(cku)
Just to be sure to have understood correctly: this was turned on long ago (47) for Nightly and Aurora, this has been now turned on in Firefox 54 for Beta and Release [still only for HTML, not SVG elements], meaning that it will ride the train once reaching Beta and Release (but not now yet).

Can you confirm or correct me?

Comment 20

2 months ago
pretty sure SVG works too.
Clear leave-open and close this bug per comment 18.

(In reply to Jean-Yves Perrier [:teoli] from comment #19)
> Can you confirm or correct me?
clip-path prop support had been enabled long time ago.
What we really enabled here is <basic-shape> value support, note that this feature was prefed on on nightly & aurora since Firefox 53(bug 1303654) and shipped since Firefox 54(this bug).
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Flags: needinfo?(cku)
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [behind pref layout.css.clip-path-shapes.enabled on Beta&Release][DevRel:P1] → [DevRel:P1]
I've updated the documentation and release notes:
https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path
https://developer.mozilla.org/en-US/Firefox/Experimental_features
https://developer.mozilla.org/en-US/Firefox/Releases/54

Sebastian
Keywords: dev-doc-needed → dev-doc-complete
Target Milestone: --- → mozilla54
relnote-firefox: ? → ---
You need to log in before you can comment on or make changes to this bug.