1303654 - Enable basic shapes clip-path clipping on Nightly & Aurora

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Per bug 1297333 comment 13, let's enable basic shapes clip-path clipping in this  bug.

Need help to decide which bugs blocking bug 1247229 also block this one.

Comment 1

[Astley Chen (inactive)]

As usual, we would like to enable this feature on nightly and aurora *by default* to collect more feedback and potential bugs before officially ship it on ALL channels.

Add dependent bugs here if you think it requires to be fixed prior to enabling.

Comment 2

[Astley Chen (inactive)]

Attachment: Bug 1303654 - Enable support for basic shapes in clip-path, on nightly & aurora.

Review commit: https://reviewboard.mozilla.org/r/89836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89836/

Comment 3

[Astley Chen (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fcafb45d7453

TRY to get up to date testing result and find out potential bugs blocking the enabling.

Comment 4

[Astley Chen (inactive)]

Target to pref on this feature on nightly & aurora from Firefox 53.

Comment 5

[Astley Chen (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a3b930c82e7a50fbe742d4bf7a91e2f319aabc9

Running TRY again before going to review.

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8806373 [details]
Bug 1303654 - Enable support for basic shapes in clip-path, on nightly & aurora.

https://reviewboard.mozilla.org/r/89836/#review93616

Commit-message nit:
>  Bug 1303654 - Enable clip-path support on nightly & aurora.

This isn't specific enough -- we already support the "clip-path" property on all channels (and have for a while).

Please replace with something like:
  "Enable support for basic shapes in clip-path, on nightly & aurora"

r=me with that.

Comment 7

[Astley Chen (inactive)]

Comment on attachment 8806373 [details]
Bug 1303654 - Enable support for basic shapes in clip-path, on nightly & aurora.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89836/diff/1-2/

Comment 8

[Astley Chen (inactive)]

(In reply to Daniel Holbert [:dholbert] from comment #6)
> Comment on attachment 8806373 [details]
> Bug 1303654 - Enable support for basic shapes in clip-path, on nightly &
> aurora.
> 
> https://reviewboard.mozilla.org/r/89836/#review93616
> 
> Commit-message nit:
> >  Bug 1303654 - Enable clip-path support on nightly & aurora.
> 
> This isn't specific enough -- we already support the "clip-path" property on
> all channels (and have for a while).

Thank you to point it out clearly. Updated the description of change-set and land a new try to ensure we are good to go before landing.

TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d5a9d7941c404a3a260777b8be93978cfc8a7c7

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f15ef37fb8d
Enable support for basic shapes in clip-path, on nightly & aurora. r=dholbert

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3f15ef37fb8d

Comment 11

[Sebastian Zartner [:sebo]]

Added notes to https://developer.mozilla.org/en-US/docs/Web/CSS/clip-path#Browser_compatibility and https://developer.mozilla.org/en-US/Firefox/Experimental_features#CSS.

Sebastian

Comment 12

[Gerry Chang [:gchang]]

Too late for 51 as we've already built RC. Mark 51 won't fix.

Comment 13

[Andrei Vaida [:avaida]]

Astley Chen, a few questions:

    1. is this feature going to ride Fx53? The title of the bug is a bit confusing, as it suggests
       that this feature is supposed to be enabled only on Nightly and Aurora.

    2. Does this feature have automated coverage?

    3. Would this feature benefit from manual testing? This is linked to the 2nd question, as it 
       depends on how much is covered through automation.

Comment 14

[Astley Chen (inactive)]

(In reply to Andrei Vaida, QA [:avaida] – please ni? me from comment #13)
> Astley Chen, a few questions:
> 
>     1. is this feature going to ride Fx53? The title of the bug is a bit
> confusing, as it suggests
>        that this feature is supposed to be enabled only on Nightly and
> Aurora.
As title suggested, at the time of landing, it's enabled ONLY on nightly and aurora channels for testing purpose. In bug 1247229, we formally shipped this feature from FF54. As a result, FF54 and later versions are the versions supporting this feature now.
 
>     2. Does this feature have automated coverage?
Yes, we have relevant reftest test cases in layout/reftests/w3c-css/submitted/masking.
 
>     3. Would this feature benefit from manual testing? This is linked to the
> 2nd question, as it 
>        depends on how much is covered through automation.
This is a CSS feature for web authors and developers, it's not user interacting features or involved with UI flow.

Thanks for your questions.

Comment 15

[Andrei Vaida [:avaida]]

Thank you for following up, Astley!