Open Bug 1248971 Opened 5 years ago Updated 2 years ago

Meta-bug for M-C problems in paragraph mode encountered by Thunderbird users (see comment #9 and comment #20)

Categories

(Thunderbird :: Message Compose Window, defect)

45 Branch
defect
Not set
major

Tracking

(thunderbird_esr45?)

Tracking Status
thunderbird_esr45 ? ---

People

(Reporter: Fallen, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: meta)

Attachments

(2 files)

I unfortunately don't have exact STR for this, but since Thunderbird 45.0b1 I am having issues writing emails. Partial STR:

1) Write some text
2) press backspace to correct things
3) type new things, press space

Now the cursor moves to an empty line above the paragraph. I may be using a mix of Body Text and Paragraph styles. Cutting all text and pasting it again makes it go away. Sometimes it just magically goes away too.

To me this is a blocker, I am totally interrupted in writing emails.
I don't see it in Windows. You're on Mac?

>  since Thunderbird 45.0b1
as compared to 38esr, or 44 beta?

Does it happen with nightly build?
Severity: normal → major
Hmm, I've been using the new paragraph mode pretty much since it landed and haven't see a problem so far. That's on Windows.

What about switching the option off:
Tools > Options, Composition, General):
  When using paragraph format, the enter key creates a new paragraph.
I've turned that option off, lets see how it goes. I guess it won't happen with that option off, since I won't have the mix of Paragraph and Body Text style as I did while manually trying to turn it off by selecting body text in the compose dialog.

It was also working in 44 beta, but again probably because that still had Body Text as the default. I'll see about nightly once I've tried the option for a while
(In reply to Jorg K (GMT+1) from comment #2)
> What about switching the option off:
> Tools > Options, Composition, General):
>   When using paragraph format, the enter key creates a new paragraph.

That doesn't seem a great solution considering that option is the default...
OS: Unspecified → Mac OS X
FWIW using backspace as a correction method has always caused problems (and they are core editor problems) It's one of my 10 commandments of html compose :). Positioning the cursor in front of the word and using the delete key works much better. Not so great for work flow, but... So bottom line, I believe this is core editor and not the recent changes. My guess is that Fallen hasn't worked in "paragraph mode" up until is was turned on by default. I'm afraid these types of problems will come up a lot with the average user as well.
(In reply to Joe Sabash [:JoeS1] from comment #5)
> So bottom line, I
> believe this is core editor and not the recent changes. My guess is that
> Fallen hasn't worked in "paragraph mode" up until is was turned on by
> default.
Absolutely +1.

But: I've been using TB in paragraph mode since before Christmas 2015 and it has worked absolutely fine. I use backspace simply because the keys is bigger. Once upon a time backspace destroyed spellcheck underlines, but Ehsan and I fixed that. So right now I can't think of any negative effect of using backspace.

If you look through M-C bugs looking for "caret" you will find 300+ bugs.
However, I doubt very much that the problem is "major" as was stated, since I haven't seen a single reproducible case.
FWIW, I've run into this on every email I've sent since updating to TB 45 last week. I thought I was going to crazy, but seems Philipp is seeing similar behavior.
If you see this on every e-mail, please give *exact* steps to reproduce. Perhaps you can even shoot a video. Which platform are you on?

I've written a few e-mails using TB 45 since Christmas and haven't seen it once (on Windows). I don't know how much I use the backspace key, but I would estimate that I use it from time to time. Actually, I do use it, mostly when at the end of the line to rub out what I've just written.

Magnus, you said that you find the new feature of composing in paragraph mode by default useful, so I assume you've been using it on Linux. Have you seen anything like what is described in this bug?
Flags: needinfo?(mkmelin+mozilla)
Attached image Screenshot of issue
(In reply to Jorg K (GMT+1) from comment #8)
> If you see this on every e-mail, please give *exact* steps to reproduce.

1. Reply to an email.
2. Type "Hello"
3. Hit enter
4. Hit backspace [2]

Behavior:
The quoted email will move *up*

Expected:
The cursor goes to the previous line.

The left side of the attachment shows the results after 3, the right side shows after 4.

I'm on Mac OS X 10.10.5. TB 45, latest beta.
I see what you mean. With backspace you're "erasing the empty paragraph" so you get into the <body> section. 
I've seen it but haven't thought of it as much of a problem. Most of the time my brain just pressed backspace one more time and that resolves it.
Flags: needinfo?(mkmelin+mozilla)
OK, I can reproduce this, I'll fill in the missing details of the exact steps to reproduce.

You're replying to a plaintext bugmail in HTML above the quote. You chose to use the new default, paragraph mode. You type Hello and <enter>.

This is what your DOM looks like at that point with the cursor positioned where indicated:
<p>Hello</p>
<p>|<br></p>
<br>
<div class=<moz-cite-prefix">, etc.

When you now press backspace, the two paragraphs get joined and the break is also deleted.

Surprisingly, the caret is not positioned after the Hello in the paragraph, but outside the paragraph in front of the (previously second, now only) br left. That's why in your picture you're seeing "Body text" in the format indicator.

That's sadly an M-C editor bug, in fact, one of the 300+ caret positioning bugs they have.

Let me attach a HTML page that will reproduce the problem in FF alone. Only like this we can convince the M-C people that there is something wrong.

I usually have to go and fix the M-C editor in these cases, as I have already done in bug 1250010 which was also revealed during paragraph editing.

Of course paragraph editing is not used anywhere on web pages, so that's why the TB users are the test rabbits.

P.S.: I don't usually see it, since I reply below the quote. I also don't usually rub out a whole paragraph.
Open the attachment and follow the instructions.
BTW, this is not what Philipp described. Quoting from comment #0:
1) Write some text
2) press backspace to correct things
3) type new things, press space
Now the cursor moves to an empty line *above* the paragraph.

Philipp: Is what is shown in attachment 8731437 [details] the problem you reported or is there another problem?
Way way back in Netscape navigator there was an option to show Paragraph marks in composition. That helped a lot to know what you were working with.
To quote the Great Gatsby: " So we beat on, boats against the current, borne back ceaselessly into the past" :) Good luck Jorg
OK, I was just about to raise a Core::Editor bug then the system pointed me to this old bug 103950 (six digits!!) from 2001.

Philipp, can you please confirm that this is the bug you're seeing or is there something else wrong?
Flags: needinfo?(philipp)
OK, I got told off for thinking that bug 103950 is the cause, so I'll ignore that 15 y/o bug. Instead I raised my own bug 1257363.
Depends on: 1257363
OS: Mac OS X → All
Hardware: Unspecified → All
jorgk, thanks for filing that! philipp, sorry if I hijacked your bug!
(In reply to Patrick Cloke [:clokep] from comment #17)
> jorgk, thanks for filing that! philipp, sorry if I hijacked your bug!
We don't know whether you hijacked it or whether you delivered the missing evidence (in which case I will change the summary soon).
Also see this 14 y/o bug that reports bad cursor positioning after pressing enter at the end of a heading: Bug 148749 (six digits, from 2002). With attachment 8731842 [details] you can reproduce this immediately.

I'm still looking for something that comes close to what Philipp described.
Depends on: 1258085
(In reply to Jorg K (GMT+1) from comment #19)
> I'm still looking for something that comes close to what Philipp described.
OK, I think I've found it and reported it as bug 1258085.

I took the liberty to hijack this bug even further and make it a meta-bug for all the M-C editor problems we encountered in paragraph mode.
Flags: needinfo?(philipp)
Summary: Pressing backspace moves the cursor to the beginning of the paragraph → Meta-bug for M-C problems in paragraph mode encountered by Thunderbird users (see comment #9 and comment #20)
Depends on: 1253288, 1250010
How long before we'll be hit by bug 968733 :-((
(Note to Joe: Delete doesn't work either).
Depends on: 968733
Depends on: 1260975
Depends on: 1263357
Depends on: 1263883
Depends on: 1265034
Depends on: 1265800
Depends on: 1266214
Duplicate of this bug: 1267098
In addition to Bug 1267098 and in reference to Jorg's Comment #6 above:
>> Once upon a time backspace destroyed spellcheck underlines...

I've had Spellcheck break a few times too in TB 45 (Release).  A correctly spelled word may be underlined right away, or a corrected word may still be underlined.

I think I was backspacing sometimes but I recall one particularly intense session where I had to make five or six different fixes (BSP, delete/retype, select/overtype, etc) to eventually remove the underline from a word that was correct in the first place.

And FYI:  Running TB45 Release on Windows 7/32 Pro (SP1).
Depends on: 1273655
Depends on: 1250805
Keywords: meta
Depends on: 1281664
Depends on: 1314790
Depends on: 1488052
You need to log in before you can comment on or make changes to this bug.