Closed Bug 1253288 Opened 8 years ago Closed 8 years ago

Take bug 1250010 "Bug in nsHTMLEditRules::ReturnInParagraph() leads to lost style (font, bold, etc.) in empty paragraph" to TB 45

Categories

(Thunderbird :: General, defect)

45 Branch
defect
Not set
normal

Tracking

(thunderbird_esr45+ fixed)

RESOLVED FIXED
Thunderbird 45.0
Tracking Status
thunderbird_esr45 + fixed

People

(Reporter: jorgk-bmo, Unassigned)

References

(Blocks 1 open bug)

Details

+++ This bug was initially created as a clone of Bug #1250010 +++

When in ReturnInParagraphCreatesNewParagraph mode, creating an empty paragraph causes <p><br></p> to be inserted. This leads to a loss of font if the previous paragraph carried a font.

Since bug 330891 composition in paragraph format has become the default in TB. Users complain about lost fonts due to bug 1250010.

This bug should therefore be landed on the TB 45 release branch after riding the trains in FF for a while. I suggest inclusion in TB 45.2.
Whiteboard: btpp-active
It's been in FF aurora now for a few days. Do you still think we should wait and not try for Thunderbird 45.0? We'd want it in the next beta, so we need to decide soon.
Up to you. No FF user splits paragraphs. Although the M-C editor is used in text input fields, most of them don't do HTML edits like we do. I've started using TB 47 which has this fix yesterday and haven't seen any problems. I agree that it would be good to ship this with the new paragraph mode.
Hi Kent, yesterday we discovered another bug that will annoy users when using paragraph mode which is now the default: Bug 1257363 (spawned off by bug 1248971 which may yield yet more M-C editor problems).
So let's take the fix for bug 1250010 to TB 45, so users won't have to fight with two annoyances. OK?
Flags: needinfo?(rkent)
Flags: needinfo?(rkent)
https://hg.mozilla.org/releases/mozilla-esr45/rev/bab23fd1d89b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
Version: Trunk → 45 Branch
Blocks: 1248971
Looks like bug 1250010 caused this regression: bug 1263883.
I'm reopening this to reuse it to land the fix for the regression, too.
Sorry about that.

Kent, this is a candidate for TB 45.1. This is a nasty little regression which is fixed in an obvious two-line change.

Let bug 1263883 land and we'll take it from there.

NI, so you don't miss the e-mail.
Status: RESOLVED → REOPENED
Depends on: 1263883
Flags: needinfo?(rkent)
Resolution: FIXED → ---
Summary: Take bug 1250010 "Bug in nsHTMLEditRules::ReturnInParagraph() leads to lost style (font, bold, etc.) in empty paragraph" to TB 45 → Take bug 1250010 "Bug in nsHTMLEditRules::ReturnInParagraph() leads to lost style (font, bold, etc.) in empty paragraph" to TB 45, also include follow up from bug 1263883.
The whole point of the bug is to track which things get landed in which version of Thunderbird, which is lost when you try to reuse the bug.

Please file a new bug for your new requirement.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Flags: needinfo?(mozilla)
Resolution: --- → FIXED
Blocks: 1265034
Never mind, I did it.
Flags: needinfo?(rkent)
Flags: needinfo?(mozilla)
Summary: Take bug 1250010 "Bug in nsHTMLEditRules::ReturnInParagraph() leads to lost style (font, bold, etc.) in empty paragraph" to TB 45, also include follow up from bug 1263883. → Take bug 1250010 "Bug in nsHTMLEditRules::ReturnInParagraph() leads to lost style (font, bold, etc.) in empty paragraph" to TB 45
You need to log in before you can comment on or make changes to this bug.