1250766 - Re-enable using Adobe GMP for decoding when system H.264/AAC codecs not available

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Now that Bug 1236756 has been fixed by Adobe, we can re-enable using the Adobe GMP for decoding when system H.264/AAC codecs are unavailable.

This means Windows XP and Windows Vista and N/KN Windows variants without the media feature packs installed will be able to decode and play MP4/H.264/AAC video.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: MozReview Request: Bug 1250766 - Re-enable using Adobe GMP for decoding when system H.264/AAC codecs not available. r?jya

Review commit: https://reviewboard.mozilla.org/r/36247/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36247/

Comment 2

[Chris Peterson [:cpeterson]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Enabling Adobe's H.264/AAC decoder means Windows XP and Windows Vista and N/KN Windows variants without the media feature packs installed will be able to decode and play MP4/H.264/AAC video. This change increases the percentage of Windows Firefox users that can play H.264 from about 85% to almost 100%.
[Suggested wording]: "Use Adobe's H.264 and AAC decoders on Windows machines without Microsoft's decoders, such as Windows XP and Vista and N/KN editions without the media feature packs installed."
[Links (documentation, blog post, etc)]:

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8722801 [details]
MozReview Request: Bug 1250766 - Re-enable using Adobe GMP for decoding when system H.264/AAC codecs not available. r?jya

https://reviewboard.mozilla.org/r/36247/#review32837

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5043859cda39

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5043859cda39

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8722801 [details]
MozReview Request: Bug 1250766 - Re-enable using Adobe GMP for decoding when system H.264/AAC codecs not available. r?jya

Requesting uplift to Firefox 46.

Approval Request Comment
[Feature/regressing bug #]: MP4/H.264/AAC decoding on Windows XP.

[User impact if declined]: Firefox users on Windows XP won't get MP4/H.264/AAC playback. This patch enables playback of MP4 videos for Windows XP users using the Adobe Gecko Media Plugin. We had this in 45, but had to turn it off due to bugs in the Adobe GMP. Those have been fixed, so we should get this uplifted so that WinXP users can finally get MP4 playback.

[Describe test coverage new/current, TreeHerder]: We have mochitests for this feature.
[Risks and why]: Low; we've been running Adobe's decoder for EME content for a while, so we're unlikely to find errors.
[String/UUID change made/needed]: None.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, let's see how this does on aurora. Wasn't there an e10s issue? Or am I thinking of something else? 
Tracking since this is enabling a new feature. 

Want this to go into the release notes for beta 46?

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8722801 [details]
MozReview Request: Bug 1250766 - Re-enable using Adobe GMP for decoding when system H.264/AAC codecs not available. r?jya

OK for aurora, has test coverage, and the blocking bugs have been fixed in 46.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #7)
> OK, let's see how this does on aurora. Wasn't there an e10s issue? Or am I
> thinking of something else?

Possibly you're thinking of Bug 1250745?

> Tracking since this is enabling a new feature. 
> 
> Want this to go into the release notes for beta 46?

Yes, this should be in the release notes.

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b0509399d94a

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Adding the relnote for 46 as suggested in comment 2. The wording is a bit long. We can work that out in the draft which I'll send round soon.

Comment 12

[Bogdan Maris, Desktop Test Engineering]

I tried some h264/AAC samples using Firefox 46 beta 8 and latest Developer Edition 47.0a2 and videos played as expected, also h.264 and MSE & H.264 are 'checked' in youtube/html5. Testing was done on Windows XP 64-bit and Windows Vista 32-bit.