1251339 - try using supported sites' favicon in content update notification

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

In bug 1238087, we're notifying users of updates and changes to sites that we support, and they care about. 

It'd be great if (for these sites, to start) we show the sites favicon in the notification, next to our build icon. For example, Facebook messenger, Gmail, etc do this with the account display picture, and their smaller build icon in the bottom right.

Talked about this with Sebastian as an idea, filing to keep track. Obviously, backwards compat wouldnt be 100% but it's a great touch for those devices that can support this.

NI-ing sebastian to see how hard this would be.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

finklebot warning: scope creep

Comment 2

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> finklebot warning: scope creep

AIUI this is not a requirement for our MVP, I assume this was just filed as an idea (and antlam says that in the description).

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Yeah, we talked briefly about this - as an enhancement for the future. I guess we'd only use a favicon that we already have available locally and not go ahead and actively search for one (which might be impossible without loading the page and parsing the content).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I'm also thinking about situations where we discover more than one update. We could be showing updates for two or more sites, kinda like Tab Queues, and using a favicon wouldn't work in the UI model.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Yeah, but I'm not overly concerned about that. Over in bug 1238087 we already created separate layouts for "1 update" and "multiple updates" that differ in details:
https://bug1238087.bmoattachments.org/attachment.cgi?id=8723718

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> Yeah, but I'm not overly concerned about that. Over in bug 1238087 we
> already created separate layouts for "1 update" and "multiple updates" that
> differ in details:
> https://bug1238087.bmoattachments.org/attachment.cgi?id=8723718

Yeah, that's what I was thinking too. 

This is not blocking anything but it adds nicely to the experience of "Firefox talking to the user". These notifications should do the best they can in that exchange to be the most useful they can be.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Content notification code was removed in bug 1396604.