1252077 - Source text of Scratchpad sources fails to load in the browser debugger.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Eddy Bruel [:ejpbruel]]

In the browser debugger, when you click on a Scratchpad source in the sources view, the source text fails to load. The reason is that Scratchpad sources use a bogus url, and we try to fetch the source text from this url.

We should instead fetch this from the text property on the corresponding Debugger.Source object, but we only do so for sources where we can identify the content type as JavaScript. If the source has a URL, we use that to make this determination, by looking at the extension. However, scratchpad sources don't have an extension, so we erroneously assume that they are not JavaScript.

There are two possible solutions here. We have a number of special cases in the debugger for special URLS. We could add another special case there for scratchpad URLs. However, I don't like adding special case code, especially if that code depends on the behavior of another tool that is not obvious unless you already know.

The other option is simply to add a ".js" extension to the URLs generated by the scratchpad. This will allow the debugger to correctly identify them as JavaScript sources.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Scratchpad URLs should have a ".js" extension

Comment 2

[Eddy Bruel [:ejpbruel]]

Try run for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e74806882cb

Comment 3

[Eddy Bruel [:ejpbruel]]

I just realised that this patch won't work, because event with a .js extension, Scratchpad URLs are still not valid URLs, and the debugger only checks the extension of URLs that it can parse. It looks like the best course of action is to add a special case for Scratchpad URLs in the debugger, after all :-(

Comment 4

[Eddy Bruel [:ejpbruel]]

Attachment: The debugger should identify the content type of Scratchpad sources as JavaScript.

See the bug description and comment 3 for an explanation of this patch.

Comment 5

[Eddy Bruel [:ejpbruel]]

Try run for the above patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=08c77f63fb29

Comment 6

[James Long (:jlongster)]

Comment on attachment 8725241 [details] [diff] [review]
The debugger should identify the content type of Scratchpad sources as JavaScript.

Review of attachment 8725241 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this solution works for me. Not ideal but it just a tiny check.

Comment 7

[Eddy Bruel [:ejpbruel]]

Try push for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a5e5b6ad949

Comment 8

[Eddy Bruel [:ejpbruel]]

Try push looks messy, but afaict, these are either known issues not related to this patch, or infra failures.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c3a501635246

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3a501635246

Comment 11

[monk-time]

It appears Bug 813087, Bug 816988 and Bug 1168560 can also be marked as FIXED. I'm happy that it's now finally possible to debug scratchpads, although a couple of issues that make it slightly inconvenient remain:

1. The Debugger window doesn't appear automatically when running a Scratchpad script as expected if Dev Tools are closed but the code has either a `debugger;` statement or a breakpoint previously set in Debugger.
2. Debugger doesn't refresh a Scratchpad script's source code after the script is rerun with some changes without refreshing the current page.