Closed Bug 1252621 Opened 6 years ago Closed 6 years ago

Loop launches a non-e10s window when running in e10s mode

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(e10s+)

RESOLVED FIXED
Tracking Status
e10s + ---

People

(Reporter: benjamin, Unassigned)

References

Details

(Whiteboard: [btpp-fix-now])

Loop launches an non-e10s window when you open it with e10s mode on. This is a terrible experience that we cannot ship.

Fixing this currently depends on loop-e10s compat work which is mostly but not completely finished.

Nominating because I think this needs to be an M8 blocker.
Rank: 15
Priority: -- → P1
Whiteboard: [btpp-fix-now]
Blocks: loop-e10s
No longer depends on: loop-e10s
The experience is pretty confusing. 
* From the initial Hello button, you get a popup with a frowny face that says "Hello doesn't work in a multi-process window" with a Launch New Window button.
* Then you get a new Firefox non-e10s window, and then should try clicking the Hello button again from that new window. It is unclear that that's what to do next. 

I think most users would assume that the Launch New Window button was going to launch a new window with Hello already active. As it is, it appears to fail.
Note: the experience was intended to be temporary whilst trying to finish the e10s work.

If really necessary we could improve it, but we'd really just like to get Hello working in e10s mode, as then you don't have the redirect to a new window at all.
and just to make it clear, the bugs blocking fixing e10s are listed in bug 1154273. I'm not quite sure why Jim changed the dependencies around.
(In reply to Mark Banner (:standard8) from comment #3)
> and just to make it clear, the bugs blocking fixing e10s are listed in bug
> 1154273. I'm not quite sure why Jim changed the dependencies around.

This is a work around that needs to be undone when the other two bugs are fixed correct? If this is not the case lets resolve this out or untrack such that it isn't on our radar.
Flags: needinfo?(standard8)
We need one bug with an tracking-e10s:M8 flag on it. I filed this bug to be that one bug. We are not willing to ship something that opens a non-e10s window in beta.

Whether we resolve this problem by fixing the dependent platform bugs/bug 1154273, or by backing out hello tab sharing, doesn't matter as much.
No longer blocks: loop-e10s
Depends on: loop-e10s
Benjamin responded to this.
Flags: needinfo?(standard8)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #1)
> The experience is pretty confusing. 
> * From the initial Hello button, you get a popup with a frowny face that
> says "Hello doesn't work in a multi-process window" with a Launch New Window
> button.
> * Then you get a new Firefox non-e10s window, and then should try clicking
> the Hello button again from that new window. It is unclear that that's what
> to do next. 
> 
> I think most users would assume that the Launch New Window button was going
> to launch a new window with Hello already active. As it is, it appears to
> fail.

I don't see this, if I click the loop button in the hamburger menu, I get a pop related to "browser this page with a friend".

Liz, can you provide better STR here?
Flags: needinfo?(lhenry)
(In reply to Jim Mathies [:jimm] from comment #7)
> I don't see this, if I click the loop button in the hamburger menu, I get a
> pop related to "browser this page with a friend".
> 
> Liz, can you provide better STR here?

You need the browser running e10s by default, and loop.remote.autostart set to its default - false.
It is working OK for me now. Benjamin can you still see it?
Flags: needinfo?(lhenry) → needinfo?(benjamin)
That must be a non-e10s window, or some inconsistency we might have - we've not changed anything wrt how Loop is working for e10s yet.
Flags: needinfo?(benjamin)
Blocks: 1258335
Rank: 15 → 9
Not sure about what to do here to be honest. From what I read on the comments it seems that:
a) it's working fine now.
b) as a workaround, it should be removed when bug 1154273 gets fixed.

If that is correct, maybe we should pump up the priority on the other bugs, not this one.
To expand on Fernando's comments, this is now basically "fixed" with bug 1256357 having landed. e10s is on in nightly and will hopefully soon be on in 47 as well.

Bug 1154273 is the meta bug for our remaining work. So do we want to keep this open for now, or can we close it and use the meta?
We believe all the blocker issues with e10s have been fixed such that we can ship to users with e10s enabled for Hello. These will hopefully today all land on central, and in a week or two be on 47 as well.

There are some outstanding issues which are tracked by the meta bug 1154273.

Hence, I'm marking this as fixed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.